From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZXfk-0001NR-VR for kexec@lists.infradead.org; Tue, 16 Aug 2016 06:16:25 +0000 Received: by mail-pa0-x242.google.com with SMTP id cf3so4740024pad.2 for ; Mon, 15 Aug 2016 23:16:04 -0700 (PDT) Subject: Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument. References: <1470956898-5991-1-git-send-email-bauerman@linux.vnet.ibm.com> <1470956898-5991-3-git-send-email-bauerman@linux.vnet.ibm.com> <20160815073049.GB21080@balbir.ozlabs.ibm.com> <1906561.y8blzB2uZ8@hactar> From: Balbir Singh Message-ID: Date: Tue, 16 Aug 2016 16:15:55 +1000 MIME-Version: 1.0 In-Reply-To: <1906561.y8blzB2uZ8@hactar> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Thiago Jung Bauermann Cc: Stewart Smith , Baoquan He , Dave Young , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , Paul Mackerras , Eric Biederman , "H. Peter Anvin" , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Vivek Goyal On 16/08/16 00:49, Thiago Jung Bauermann wrote: > Am Montag, 15 August 2016, 17:30:49 schrieb Balbir Singh: >> On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote: >>> Adapt all callers to the new function prototype. >> >> Could you please expand on this? > > Is the following better? > > Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer. Yes and the reason for doing so? Consolidation/clarity of implementation? > >> Looks good otherwise >> >> Acked-by: Balbir Singh > > Thank you for reviewing this series! > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec