From: Eric DeVolder <eric.devolder@oracle.com>
To: Baoquan He <bhe@redhat.com>
Cc: andrew.cooper3@citrix.com, daniel.kiper@oracle.com,
horms@verge.net.au, kexec@lists.infradead.org,
konrad.wilk@oracle.com
Subject: Re: [PATCH] Handle additional e820 memmap type strings
Date: Wed, 17 May 2017 07:51:06 -0500 [thread overview]
Message-ID: <ff7c75d3-2b12-fe7a-8ede-ec04a6161665@oracle.com> (raw)
In-Reply-To: <20170515140711.GB21797@x1>
On 05/15/2017 09:07 AM, Baoquan He wrote:
> On 05/10/17 at 11:03am, Eric DeVolder wrote:
>> Keep pace with changes to linux arch/x86/kernel/e820.c to
>> function e820_type_to_string(). With this change, the following
>> messages from kexec are eliminated (and allows kexec to load):
>>
>> Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type.
>> Please report this as bug. Using RANGE_RESERVED now.
>>
>> Unknown type (Unknown E820 type) while parsing /sys/firmware/memmap/4/type.
>> Please report this as bug. Using RANGE_RESERVED now.
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> ---
>> kexec/firmware_memmap.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
>> index 4d84f00..1ee214a 100644
>> --- a/kexec/firmware_memmap.c
>> +++ b/kexec/firmware_memmap.c
>> @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct memory_range *range)
>> range->type = RANGE_RESERVED;
>> else if (strcmp(type, "reserved") == 0)
>> range->type = RANGE_RESERVED;
>> + else if (strcmp(type, "Reserved") == 0)
>> + range->type = RANGE_RESERVED;
>> + else if (strcmp(type, "Unknown E820 type") == 0)
>> + range->type = RANGE_RESERVED;
>
> Should we change the "reserved" one to "Reserved" so that we don't need
> to have "reserved" and "Reserved" at the same time?
The lower-case "reserved" has been in use by the kernel for quite a long
while, and upper-case "Reserved" has been recently introduced. I think
removing lower-case "reserved" would result in problems with existing,
older, kernels that still would be using "reserved".
>
>> else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
>> range->type = RANGE_ACPI_NVS;
>> else if (strcmp(type, "Uncached RAM") == 0)
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-05-17 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:03 [PATCH] Handle additional e820 memmap type strings Eric DeVolder
2017-05-14 23:28 ` Eric DeVolder
2017-05-15 14:07 ` Baoquan He
2017-05-17 12:51 ` Eric DeVolder [this message]
2017-05-19 9:15 ` Baoquan He
2017-05-22 11:43 ` Simon Horman
2017-05-23 14:08 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7c75d3-2b12-fe7a-8ede-ec04a6161665@oracle.com \
--to=eric.devolder@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=bhe@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox