From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>,
kexec@lists.infradead.org, linux-doc@vger.kernel.org
Cc: bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com,
corbet@lwn.net, linux-kernel@vger.kernel.org,
linux-debuggers@vger.kernel.org, kernel@gpiccoli.net,
kernel-dev@igalia.com
Subject: Re: [PATCH] Documentation: Improve crash_kexec_post_notifiers description
Date: Fri, 30 Aug 2024 15:23:45 -0300 [thread overview]
Message-ID: <ffe4b1ac-926e-7f99-900b-707384f09462@igalia.com> (raw)
In-Reply-To: <87ed66q6d5.fsf@oracle.com>
On 30/08/2024 14:15, Stephen Brennan wrote:
> [...]
>
> This is definitely clearer and an improvement! But I didn't (and still
> don't) love the phrase "users who doubt kdump will succeed" because I
> think that implies user error or silly beliefs.
>
> What if these two sentences read something like:
>
> In configurations where kdump may not be reliable, running the panic
> notifiers can allow collecting more data on dmesg, like stack traces
> from other CPUS or extra data dumped by panic_print.
>
>> Notice that some code
>> + enables this option unconditionally, like Hyper-V,
>> + PowerPC (fadump) and AMD SEV.
>
> Yes, great addition.
>
> With or without my suggestions it's an improvement, so:
>
> Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
>
Thanks Stephen, I agree - your wording sounds better.
I've incorporated that in the just sent V2.
Cheers,
Guilherme
P.S. I'll be OOO some days, so expect a bit of delay in case there are
more reviews/interactions.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2024-08-30 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 14:03 [PATCH] Documentation: Improve crash_kexec_post_notifiers description Guilherme G. Piccoli
2024-08-30 17:15 ` Stephen Brennan
2024-08-30 18:23 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffe4b1ac-926e-7f99-900b-707384f09462@igalia.com \
--to=gpiccoli@igalia.com \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox