From: ebiederm@xmission.com (Eric W. Biederman)
To: Vivek Goyal <vgoyal@redhat.com>
Cc: jeremy@xensource.com,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
the arch/x86 maintainers <x86@kernel.org>,
Daniel Hecht <dhecht@vmware.com>,
LKML <linux-kernel@vger.kernel.org>,
Haren Myneni <hbabu@us.ibm.com>,
Alok Kataria <akataria@vmware.com>
Subject: Re: [RFC PATCH] Bug during kexec...not all cpus are stopped
Date: Mon, 11 Oct 2010 15:10:11 -0700 [thread overview]
Message-ID: <m1hbgs5qkc.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20101011213901.GR12743@redhat.com> (Vivek Goyal's message of "Mon, 11 Oct 2010 17:39:01 -0400")
Vivek Goyal <vgoyal@redhat.com> writes:
> On Mon, Oct 11, 2010 at 12:41:23PM -0700, Alok Kataria wrote:
> I don't think that kdump path uses smp_send_stop().
It doesn't.
> IIUC, on x86, we directly send NMI to other cpus.
>
> native_machine_crash_shutdown()
> kdump_nmi_shootdown_cpus()
> nmi_shootdown_cpus()
> smp_send_nmi_allbutself
> apic->send_IPI_allbutself(NMI_VECTOR);
>
> So above description should be limited to only panic() path.
Is it actually confusing? With respect to documenting the line
of thinking it seems reasonable.
> On a side note, I am wondering why panic() and kdump path can't share the
> shutdown routine.
Hysterical raisins. Andi's change to smp_send_stop says that NMIs not
working on some boxes. When someone wants to weed through all of the
insanity it would probably be good to get the panic and the kdump paths
sharing code. For now simply separating panic and reboot should be
enough, and it lets the code evolve where it needs to.
Eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-10-11 22:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 20:34 [RFC PATCH] Bug during kexec...not all cpus are stopped Alok Kataria
2010-10-11 17:09 ` Alok Kataria
2010-10-11 18:07 ` Eric W. Biederman
2010-10-11 19:41 ` Alok Kataria
2010-10-11 21:17 ` Eric W. Biederman
2010-10-11 21:37 ` Alok Kataria
2010-10-11 21:39 ` Vivek Goyal
2010-10-11 21:47 ` Alok Kataria
2010-10-11 22:10 ` Eric W. Biederman [this message]
2010-10-12 22:17 ` Vivek Goyal
2010-10-13 0:23 ` Alok Kataria
2010-10-21 19:09 ` Alok Kataria
2010-10-21 20:26 ` H. Peter Anvin
2010-10-21 21:10 ` Alok Kataria
2010-10-21 21:24 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hbgs5qkc.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akataria@vmware.com \
--cc=dhecht@vmware.com \
--cc=hbabu@us.ibm.com \
--cc=jeremy@xensource.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox