From: ebiederm@xmission.com (Eric W. Biederman)
To: CAI Qian <caiqian@redhat.com>
Cc: Simon Horman <horms@verge.net.au>,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [GIT PULL] Please pull x86 biarch crashdump support and misc devel
Date: Fri, 10 Sep 2010 21:00:09 -0700 [thread overview]
Message-ID: <m1zkvp3p6e.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <2021475052.729451284170746624.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (CAI Qian's message of "Fri, 10 Sep 2010 22:05:46 -0400 (EDT)")
CAI Qian <caiqian@redhat.com> writes:
>> This failed to build for me.
>>
>> kexec/arch/i386/crashdump-x86.c: In function
>> ‘load_crashdump_segments’:
>> kexec/arch/i386/crashdump-x86.c:703: error: ‘KEXEC_ARCH_NATIVE’
>> undeclared (first use in this function)
>> kexec/arch/i386/crashdump-x86.c:703: error: (Each undeclared
>> identifier is reported only once
>> kexec/arch/i386/crashdump-x86.c:703: error: for each function it
>> appears in.)
>> make: *** [kexec/arch/i386/crashdump-x86.o] Error 1
>> >
>> > The active part of the fix is below (I have an earlier patch that
>> > just
>> > defines KEXEC_ARCH_NATIVE).
> I just realized you said the earlier patch defined KEXEC_ARCH_NATIVE. Now, kexec failed to load.
> /sbin/kexec -p '--command-line=ro root=/dev/mapper/vg_intels3e3601-lv_root rd_LVM_LV=vg_intels3e3601/lv_root rd_LVM_LV=vg_intels3e3601/lv_swap rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYBOARDTYPE=pc KEYTABLE=us console=ttyS0,115200n81 irqpoll maxcpus=1 reset_devices cgroup_disable=memory sysrq_always_enabled ' --initrd=/boot/initrd-2.6.36-rc2-mm1-fix+kdump.img /boot/vmlinuz-2.6.36-rc2-mm1-fix+
> unsupported crashdump architecture: 5c420000
> Cannot load /boot/vmlinuz-2.6.36-rc2-mm1-fix+
!@#$@! I was reading from the wrong variable. My apologies. I really
did mean to give you something that would work.
I have fixed the wrong variable problem and I also spotted another
architecture test in crashdump-x86e that would only work on i386, and
fixed that.
The new version is up at:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/kexec-tools-devel.git
So if you want to live on the bleeding edge and see if I have fixed
all of my thinkos you can test that.
I hope this gets the weird biarch software architecture right finally.
Eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-09-11 4:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <575742837.695351284137649163.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 16:54 ` [GIT PULL] Please pull x86 biarch crashdump support and misc devel caiqian
2010-09-10 19:15 ` Eric W. Biederman
2010-09-10 19:19 ` Eric W. Biederman
2010-09-11 1:40 ` CAI Qian
2010-09-11 2:05 ` CAI Qian
2010-09-11 4:00 ` Eric W. Biederman [this message]
[not found] <1780019082.729911284179131961.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-11 4:25 ` caiqian
2010-09-11 4:53 ` Eric W. Biederman
2010-09-11 5:47 ` Eric W. Biederman
2010-09-11 13:48 ` CAI Qian
[not found] <453826608.695091284137315385.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 16:49 ` caiqian
[not found] <822803231.671471284126247290.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 13:45 ` caiqian
2010-09-08 19:44 Eric W. Biederman
2010-09-08 19:51 ` Eric W. Biederman
2010-09-09 1:35 ` Simon Horman
2010-09-09 1:46 ` Eric W. Biederman
2010-09-09 2:42 ` Simon Horman
2010-09-09 5:59 ` Eric W. Biederman
2010-09-09 8:14 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zkvp3p6e.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=caiqian@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox