From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC7BCC6B1C for ; Tue, 13 Oct 2026 16:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eamPwVaY6pN93fvXHVUmbGw8UIldf2fAJBG+vjxWeX0=; b=lVwPRK1U7ds3p5ydvHBLZvK+oZ nwTbmwOD9UIP5dZ7HUS1QgSNYNSU3zH2ce4itaXVkAFcPu2Od3xUMfeC9U7LNAh6WpV8X0qokCgx3 y/ZnRXC6hlnF2zFe21iK4qxEM74RehNjUcU4o0R7IyGdMAiTInPV58NhvGho/Ywe5vPA5c+TxE5Ri YrOkTRExHqC5haYMl9HWPDvqKksgMS09c+S8D8N9FvJlExKR0azdv8WuKVflOx9QnhLH3eyVSiVp5 2ogJi/YAYMLoK25KHSKN8X4rQgwTVE98YSls5OT4whWDDeKHKtIbYndPbLl7G0yRxgRW6TcBH+wWf k1/lVWHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGfSw-0000000DXT3-16D5; Tue, 13 Oct 2026 16:35:02 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGfSt-0000000DXNl-3YrU for kexec@lists.infradead.org; Tue, 13 Oct 2026 16:34:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6EA0E43BAB; Tue, 13 Oct 2026 16:34:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3E5E1F00898; Tue, 13 Oct 2026 16:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791909299; bh=eamPwVaY6pN93fvXHVUmbGw8UIldf2fAJBG+vjxWeX0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ntzT+lTWTbiwjB54PNqFtExJY9KfCBZ7v8ywXVFdy+3XeENbQJJHy4A6HxgL6Ocf1 VQXQmrazQPQcsiKYDJhacBSS10a0pSCPGHZ+ZSnIiTsATvr2pfNg4kOtGJOda8cJQM aBPVEgxyJS3L19ckKyuodos0UkzVZ9P5BURVIJ1cjze+2Fbm/RzV9N54qdS1JswAJG 4ijSneeCb3WJV33vGKXNxmYt1RxfHHImXdVCKDTnt5e2VrS49q4QCZWQkhViaKJvS9 YSTWg2eWZm1zOeywqJZ1kBZGRtsa5rZPteR3LOTcXeSA3mktO5PJE+oi5TFayg6a6V ckUqz0cc0j7JA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 09/13] PCI: liveupdate: Adopt ACS controls in incoming preserved devices To: "David Matlack" , kexec@lists.infradead.org, linux-pci@vger.kernel.org Cc: "Adithya Jayachandran" , "Alexander Graf" , "Alex Williamson" , "Bjorn Helgaas" , "Chris Li" , "David Rientjes" , "Jacob Pan" , "Jason Gunthorpe" , "Jonathan Corbet" , "Josh Hilke" , "Leon Romanovsky" , "Lukas Wunner" , "Mike Rapoport" , "Parav Pandit" , "Pasha Tatashin" , "Pranjal Shrivastava" , "Pratyush Yadav" , "Randy Dunlap" , "Saeed Mahameed" , "Samiullah Khawaja" , "Shuah Khan" , "Vipin Sharma" , "William Tu" , "Yi Liu" In-Reply-To: <20261013162529.1928093-10-dmatlack@google.com> References: <20261013162529.1928093-1-dmatlack@google.com> <20261013162529.1928093-10-dmatlack@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 16:34:57 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org > Adopt Access Control Services (ACS) controls on all incoming preserved > devices (endpoints and upstream bridges) during a Live Update. >=20 > Inheriting ACS flags avoids changing routing rules while memory > transactions are in flight from preserved devices. This is also strictly > necessary to ensure that IOMMU group assignments do not change during or > after Live Update. >=20 > The adopted controls are recorded by the pci_save_state() call in > pci_bus_add_device(), which runs before drivers bind, so they are > automatically reapplied by pci_restore_state() if the device is reset. > If that save buffer could not be allocated there is nowhere to record > the adopted controls, and they would be silently lost by the first > reset. Program ACS from scratch in that case, which is a better outcome > than leaving ACS disabled. >=20 > To simplify ACS inheritance, reject preserving any devices that require > quirks to enable ACS as those quirks would also have to take Live Update > into account. >=20 > Signed-off-by: David Matlack Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261013162529.1928= 093-1-dmatlack@google.com?part=3D9