From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 592C1CC6B0E for ; Tue, 13 Oct 2026 16:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a0HIsecP77lzQZZppYz4eZx4iBntpmKFcBBBTudX1wU=; b=Zi7X+LOqMOUThSgichJ1KkACtl +poglIiIG5bfrPEWHE7SbMhHdp6F+Se9kzyp+twMgzU6vzNMRsp9nte47d1ZQfuFRlTG5YdCnlwxO /iTMPSDWl5UejPzMxc9vt3BH6ZksC/3UvwUMqI+hCave6n+VLuiOv2h3ZWDovyLNimwiOUwArMFZg f9Zfl9r4rnt9MdB1W34+sDVxqADSAkV8x9z/H3wg4+vZflW90lao619RSCvLvcYjbyer9+n+SCLjn 9QsEs1MDdKY0Kl36rX0lX5dV5z7BkeaQPq9ApKRtfKIQzu5m+qkCSF4CpQrYRPHn1DOqwzjLhdnu+ 0y/4gwbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGfXk-0000000DZ0d-2RuF; Tue, 13 Oct 2026 16:40:00 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGfXh-0000000DZ0G-3w4I for kexec@lists.infradead.org; Tue, 13 Oct 2026 16:39:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 61FEA60A56; Tue, 13 Oct 2026 16:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D6061F000FF; Tue, 13 Oct 2026 16:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791909597; bh=a0HIsecP77lzQZZppYz4eZx4iBntpmKFcBBBTudX1wU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KvdgtXVWTwSNmjsP2kz7kh7UTl5Vn2N7E2h1mgnGpah5z2cQGxZNeiLfNnEgM4i+R GdCgMyLPiBxo427bSep4saLIJGUkhviJyxHB0tELG1JtUA6ARhLuCuejd2t7/fC5Fe ZYoYuJuaL5VIeZn8X4WVqMEQ7y43I9ddnhGMbAFeJUo+dBal/VMzPOdVxqexU2NxLj DS/uUUWep9nbOpA7ZsYNziqeTW0OPtVVEQtycvgBvxz5V+hih3OMFOC9sIH24WYURP RU1wA1HQVWXCpl/qBtK7PT7puKiQGlZoLQ/K4gUVthcr9SZxqU8gVt0RU1D4Eapo8D sFFNV+966nXag== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 06/13] PCI: liveupdate: Preserve bus numbers during Live Update To: "David Matlack" , kexec@lists.infradead.org, linux-pci@vger.kernel.org Cc: "Adithya Jayachandran" , "Alexander Graf" , "Alex Williamson" , "Bjorn Helgaas" , "Chris Li" , "David Rientjes" , "Jacob Pan" , "Jason Gunthorpe" , "Jonathan Corbet" , "Josh Hilke" , "Leon Romanovsky" , "Lukas Wunner" , "Mike Rapoport" , "Parav Pandit" , "Pasha Tatashin" , "Pranjal Shrivastava" , "Pratyush Yadav" , "Randy Dunlap" , "Saeed Mahameed" , "Samiullah Khawaja" , "Shuah Khan" , "Vipin Sharma" , "William Tu" , "Yi Liu" In-Reply-To: <20261013162529.1928093-7-dmatlack@google.com> References: <20261013162529.1928093-1-dmatlack@google.com> <20261013162529.1928093-7-dmatlack@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 16:39:55 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org > Keep the secondary and subordinate bus numbers that the previous kernel > programmed into bridges, rather than assigning new ones, if the previous > kernel preserved any device across a Live Update. Do this even on > architectures that would otherwise always assign bus numbers themselves, > e.g. when pci=3Dassign-busses is passed. >=20 > Preserved devices must be allowed to continue performing memory > transactions across a Live Update, so the kernel cannot change the > fabric topology. Changing the bus numbers of a bridge changes the > RequesterIDs of the devices below it, which would require disabling and > flushing any in-flight memory transactions first. >=20 > Apply the policy globally rather than only to the paths that contain > preserved devices. Bus numbers have to be preserved above a preserved > device anyway, since an upstream bridge cannot expand its window. A > [ ... ] > Require that CONFIG_CARDBUS is not enabled to enable > CONFIG_PCI_LIVEUPDATE since preserving bus numbers on PCI-to-CardBus > bridges requires additional work but is not a priority at the moment. >=20 > Signed-off-by: David Matlack Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261013162529.1928= 093-1-dmatlack@google.com?part=3D6