Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>, "Shuah Khan" <shuah@kernel.org>
Cc: "David Woodhouse" <dwmw@amazon.co.uk>,
	"Nageswara R Sastry" <rnsastry@linux.ibm.com>,
	kexec@lists.infradead.org
Subject: Re: [PATCH 4/5] selftests/kexec: select tests using the target compiler
Date: Wed, 14 Oct 2026 20:08:00 +0000	[thread overview]
Message-ID: <sashiko-outbox-171823@kernel.org> (raw)
In-Reply-To: <20261014200127.1363472-5-sashal@kernel.org>

> The kexec Makefile recognizes PowerPC only through the ppc64le spelling
> of ARCH, so the canonical ARCH=powerpc used for cross builds omits the
> tests. The x86 jump test is selected with IS_64_BIT from
> scripts/Makefile.arch, which describes the build host rather than the
> compiler being used. On other architectures the Makefile includes no
> lib.mk rules at all, so installation and runlist generation fail with
> missing targets.
> 
> Select x86 and PowerPC from the target ARCH when it is given and from
> the host's SUBARCH otherwise, without assigning ARCH, so that lib.mk
> keeps choosing the compiler's native clang target. Ask the selected
> compiler, including USERCFLAGS, whether it targets a 64-bit x86 ABI
> and whether it targets little-endian 64-bit PowerPC. lib.mk expands the
> generated program list before it appends USERCFLAGS to CFLAGS, so the
> flags are passed explicitly to keep both probes consistent. If the
> compiler cannot be run, select the jump test so that the build fails
> instead of silently dropping it. Include lib.mk unconditionally so that
> unsupported targets build, install and emit an empty runlist.
> 
> Fixes: 65e38e32a959 ("selftests/kexec: Enable secureboot tests for PowerPC")
> Fixes: 7615b94b6371 ("selftests/kexec: Add x86_64 selftest for kexec-jump and exception handling")
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014200127.1363472-1-sashal@kernel.org?part=4



      reply	other threads:[~2026-10-14 20:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 20:01 [PATCH 0/5] selftests: target selection fixes for cross and LLVM builds Sasha Levin
2026-10-14 20:01 ` [PATCH 4/5] selftests/kexec: select tests using the target compiler Sasha Levin
2026-10-14 20:08   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-171823@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=kexec@lists.infradead.org \
    --cc=rnsastry@linux.ibm.com \
    --cc=sashal@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox