From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F5DB606D54F for ; Tue, 20 Oct 2026 16:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lzv00s0C DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TMQGJ5fJ9MCh2/Z4MJkdTHs79RpV7IxXJFfpO1AlsOs=; b=lzv00s0Ce3A9ZhA60J1UYB4KyW zeJ5EvRVClX+4fTDOKXbUeBJ/94ttuNxmxjLPeekvMoZn7pdBLICTUtoF+IWuMGElPIdBCMqQXM9O G0iHPxHe3715bmplq+TnqGk5noBOC59DMs5WSzhODa6MbwAX8SNZ0zc9iBrlxJDf59gfpMLs4W0YB YLnn5boeZT46dXZp1AddBs/XNgqj3qeYeViRuCczGyZzIaTJsFIS0hfxYZl6olGKmGw9/2ROzIZsm fJpHYIDifqLeSdYGU6XdF/Ezt0oh2Y7vTZiZZI6PUzYFWLLQRinOnVSlXXyY+BxAdWwybNDkB9is6 TkJfSb1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJD1h-0000000AF3j-2zOT; Tue, 20 Oct 2026 16:49:25 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJD1g-0000000AF3T-1tUD for kexec@lists.infradead.org; Tue, 20 Oct 2026 16:49:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 569B86020C; Tue, 20 Oct 2026 16:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20C001F000C9; Tue, 20 Oct 2026 16:49:22 +0000 (UTC) Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device To: "David Jeffery" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Danilo Krummrich" Cc: linux-pci@vger.kernel.org, "Tarun Sahu" , "Stuart Hayes" , "Laurence Oberman" , "Bjorn Helgaas" , kexec@lists.infradead.org, "Ewan Milne" , "John Meneghini" , =?utf-8?b?TG9tYmFyZGksIE1hdXJpemlv?= , "Bart Van Assche" , "John Garry" , "Jeremy Allison" , "Martin K . Petersen" , "Pasha Tatashin" In-Reply-To: <20261020164435.80499-4-djeffery@redhat.com> References: <20261020164435.80499-1-djeffery@redhat.com> <20261020164435.80499-4-djeffery@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 16:48:51 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Currently, no device has need_parent_lock set and is moved by > device_move. need_parent_lock is only set by the usb bus and very > few device types ever use device_move. >=20 > Add a warning to device_move to catch should it ever be used on a > device with need_parent_lock set. The combination would break > the immutable relationship needed between parent and child for > need_parent_lock when locking and unlocking both. >=20 > Suggested-by: Tarun Sahu > Signed-off-by: David Jeffery Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261020164435.8049= 9-1-djeffery@redhat.com?part=3D3