From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B940606A31B for ; Tue, 27 Oct 2026 00:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Q1luDjsp; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=J+iP5PZb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=zj/Mv6aXUjBoMZYd0eJh9B44Dd/H6hlsZebSXD3UVfU=; b=Q1luDjspXg0QHSEAqW2CzcAPks HhsM7nDxBT3KJ15pcPQysJ4SCxXX/gIS6LsnRFMyLGSGWLjV2aMHVebdEuqzJHYkdyCmyWdN0//Nv 9eJXosSKXVVJkJ7uwloCteHeRCUJ5VRwXJsN210wH5/Uh9SpVludXdhI/HADsyJ1Tzs8RcVYYMdSO aazb1Qo2ZcW9/orlkW3GwgyRpyxDhrMwHKmK3khJZ2Q11/mJyXz0fpe4B3eJreAbh2MsR/zMK8M7U MTFsAMFjwob4F5EfLILkcYQll8g56jgjxhdsHmw5zOTvJfQUYrV0EyxaYyygilC2PlOZYUmgfjE6p BmhdSUTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUnn-00000003UqG-3Jsp; Tue, 27 Oct 2026 00:12:31 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUnm-00000003UoX-0Vrx for kexec@lists.infradead.org; Tue, 27 Oct 2026 00:12:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 521A6601FE; Tue, 27 Oct 2026 00:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 791881F01828; Tue, 27 Oct 2026 00:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793059949; bh=zj/Mv6aXUjBoMZYd0eJh9B44Dd/H6hlsZebSXD3UVfU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=J+iP5PZbrXnlg8USL0R94A+LcSIf47hNeL368w3Ux2ctXr7HSwaUcS/eY3ngJp/ah NCw9moego/a0kRQUel+YVHWz9viJ8k0GiubRn6HKMKkJoy1BoHmALwOF/VcWuJdZzA xKMGjUJdQrr0lR2KgmQyGmQmMCWgaJA5YaNw4lhO9dLeFQDxzSe6jt1cQ0bk29AI5b 2Wjt77PXW4uZPocnFy1hjWsN7sK474jAbncRM51QpH1d0xqIh6wQ0t+VJUuN9h+abs BX7o4HhM5clc2xZG83bf1RTYvloo+P3lQuyB2VyoYxo66tcvQgrV6oub9K1bv7NQC8 PMNjgjxRHPCrg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 08/46] mm/filemap: finish fault cleanup before dropping the fault lock To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Chris Mason" In-Reply-To: <20261027-fixes_core-v1-8-6f74bec9a5bb@kernel.org> References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-8-6f74bec9a5bb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Oct 2026 00:12:26 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > On a retried fault, a fatal signal interrupting the folio lock wait > makes lock_folio_maybe_drop_mmap() drop the fault lock without pinning > the file. However, filemap_fault() may still need to release > mapping->invalidate_lock. A concurrent munmap() can release the last > file reference and free the mapping before that unlock. >=20 > Defer dropping the fault lock to filemap_fault()'s retry cleanup, after > releasing invalidate_lock. If the fault lock was already dropped for > I/O, release the existing file reference instead. Keep the fault lock > held for FAULT_FLAG_RETRY_NOWAIT as before. >=20 > Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache w= ith invalidate_lock") > Cc: stable@vger.kernel.org > Reported-by: Chris Mason > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-fixes_core= -v1-0-6f74bec9a5bb@kernel.org?part=3D8