From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86A4E606A31A for ; Tue, 27 Oct 2026 00:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=k021WUeV; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=brGcxURp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=+DSZywh5EFbfU/d0cC1YRtz7IDUUXYFc3HL4otefIkE=; b=k021WUeVVubOHy4KShld0wMdk2 xKJ8dUh5nFwKoTBT4vuarMXhSTK/eZFejb4bMWoZuWtx8R4LBWpYXCdLSdxv1bef56FgpRorfLuAh w4F7X9P4dd/mtRXoZnhUotWQsQSrvNXVs6WGV1SrsLDt00VCB/J/Gtd3Ci10s/aogS9I+zMI90EkJ 6V4EY/yO2dKY31hbNWVZxFgt0jvonxay/MuTrTq9b8P+rtG6tMzQJpDmh9xHLlwVStSOZUC/sUwm5 o56trE0jtJr4uGzfvpzej8JJ8+kgYaux0dD5T+931AeQccSnRlRtCEm85kz5bNKAXUJ1hwxe6BIHJ lqRlW8Dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUom-00000003Vcj-14mL; Tue, 27 Oct 2026 00:13:32 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUol-00000003Vc1-08PT for kexec@lists.infradead.org; Tue, 27 Oct 2026 00:13:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C464240E54; Tue, 27 Oct 2026 00:13:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4D061F01825; Tue, 27 Oct 2026 00:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793060010; bh=+DSZywh5EFbfU/d0cC1YRtz7IDUUXYFc3HL4otefIkE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=brGcxURpvj5J0/vSUUUzj7QnqBrWv9L0qGg4ykto2FqBhAcfd1ZkC4I5c33KKeAPg tswtwWOe4ysPgS1TRUTUTQ84KqDxy9h/W+FHUojNHo7dbTlfnL2cedhhZhGOZiFxf7 RirN9Nh8kKNW1+iqvVtCh9DXOY4Zxc/KmGVlRGF+97X1sbhYtEnjhcEP3qNL+LO9J8 88ODZnGjdNMcMjTGf9SySskajfcTwcAvj/Vw5GSeL55r4IfngFHO2JiXSgUcOtwLcI pe54h0n8bFr32Tt0jD6BunsqWarKXMp/MzCwvxARsXRZ0lhzVPBb40XxaD5QeOzqV1 ZXv5IaRMmpY1A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 27/46] mm/mmu_notifier: finish non-blocking interval invalidation on error To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261027-fixes_core-v1-27-6f74bec9a5bb@kernel.org> References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-27-6f74bec9a5bb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Oct 2026 00:13:27 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Josef Bacik >=20 > When an ordinary MMU notifier rejects a non-blocking invalidation, the > interval invalidation started beforehand is left unfinished: the caller > skips mmu_notifier_invalidate_range_end(). Subsequent interval notifier > operations can then wait forever. >=20 > The only in-tree trigger is nouveau SVM, which uses both notifier types > and rejects non-blocking invalidations. Reaping via the OOM reaper or > process_mrelease() can therefore leave the GPU fault worker stuck, > holding a reference that prevents the dying process's address space > and memory from being freed. >=20 > End the interval invalidation when an ordinary notifier fails a > non-blocking invalidation, like mn_itree_invalidate() already does when > an interval notifier fails. Make that handling clearer in the > documentation of mmu_notifier_invalidate_range_start_nonblock(). >=20 > Fix generated by an LLM and sent by Josef Bacik in private. >=20 > Fixes: 99cb252f5e68 ("mm/mmu_notifier: add an interval tree notifier") > Cc: stable@vger.kernel.org > Signed-off-by: Josef Bacik > [ david: simplify description, update function doc ] > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-fixes_core= -v1-0-6f74bec9a5bb@kernel.org?part=3D27