From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFEA2606A31A for ; Tue, 27 Oct 2026 00:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=b7MQibd0; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=RTdzx5Bb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=nkwBi9BJ0TSBIw3smCm3mz+RdUrBBbs6DBCZo7EjNis=; b=b7MQibd0xlWPInt74FZ9/ihg+O kCu10Cgn7+UH0Pwckqk4bOyMiWHWOfFBRZaj7EMbPy0obnLJIfkDSaMKRFN0YggQUIkibyGq0sIbN GPVpBeA+DRw4V5QGvyiKK8YBE8GyUmIeXs/dhySSff/Lx2wgBpQ6pTgNZKbNRDtLBpRSKTgdNJUXM MySd3tr46//BQY34McTmGdi2c4eCiw86V4fBpRK/38SqWkD87YWi2xjHfcQPR/qW6mU6qmXzlUMOE LZ5X2XObgcAihoAHr1v65sJ94fGlrTzigDdyv8CNVJ1c5Frw9MzmtAg5GjlfweJS+guu+uSN445FV PVBiueWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUop-00000003VfP-2h51; Tue, 27 Oct 2026 00:13:35 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUoo-00000003VeN-2APZ for kexec@lists.infradead.org; Tue, 27 Oct 2026 00:13:34 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3B1F140E59; Tue, 27 Oct 2026 00:13:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27B591F01825; Tue, 27 Oct 2026 00:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793060014; bh=nkwBi9BJ0TSBIw3smCm3mz+RdUrBBbs6DBCZo7EjNis=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RTdzx5Bbv9ksnSKgBJc06mGY5D1dujpHOZ3MOUujvvoklon9ejOcb9OeKWaiEMYX6 QrudYtplZqzV9b9J3FUUOaTbGZS6hC5i5kfnJyCrssFty9nAjaDsFlLzin4EfEvwfz ml4fJeQcwl2p77V+nUYJLhOsKxImGO8SmuRXz3FE7w7HBVYKy4nb6cWDcOSv7SJjSS VJOAh4x6I9gPMnd3ZRhT0/gHaJm450+im04+xuANmwO7kWtFTdqyp+jNrXJnSiB0yj 7Yla6MRYY4G487L+VY5f5sU3RdO7Y6aM9mY+fmhDK2quNWeIiGarbX0/RUoYtxQaqF uUPLlTmwgL2+g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 28/46] mm/mmu_notifier: set ->mm only after mmgrab() To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Chris Mason" In-Reply-To: <20261027-fixes_core-v1-28-6f74bec9a5bb@kernel.org> References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-28-6f74bec9a5bb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Oct 2026 00:13:30 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Chris Mason >=20 > Radeon uses a non-NULL notifier->mm to decide whether to call > mmu_interval_notifier_remove() when freeing a buffer object. > __mmu_interval_notifier_insert() sets ->mm before validating the range, > so a wrapping userptr range can leave ->mm set after insertion fails. > Cleanup then tries to remove an unregistered notifier for which no mm > reference was acquired. >=20 > Set ->mm only after mmgrab(), once insertion can no longer fail. While > we could fix radeon's code instead, setting ->mm on success only makes > the code more robust. >=20 > Fix generated by an LLM and sent by Chris Mason in private. >=20 > Fixes: 3506ff69c3ec ("drm/radeon: use mmu_interval_notifier_insert") > Cc: stable@vger.kernel.org > Signed-off-by: Chris Mason > [ david: simplify description ] > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-fixes_core= -v1-0-6f74bec9a5bb@kernel.org?part=3D28