From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CF8606A31B for ; Tue, 27 Oct 2026 00:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nI328k5j; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZRyUjmLK DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=152UiJQPSd0WWhRV/RFm1y/NO86IHZgmxHUUAdsl+ps=; b=nI328k5jWF9t3jX3kbbZ+1Hkz2 BmGJRghXmN3X9qQPCEXBUy/O6IZhICHvKjAr9LvqJh6pIu0fGX90Z6N/ln2eqf4eXNo7faRUnxie0 CNAfENxQ1bEsG8kuCoSzHDjzlG1SOrRiWZCKH9z9iOm1+j2E5lIVTSJz51B1Ql3y8vhgSbDdEy+Y3 8JetXdm8fB3MB8RIhtBFkUSngACgyJFl03ebMx3zLB3mKuajK8PgRJ52Z3evrFJgluhh4X6IEQVG0 8NiOu8VUQKU3Ls0dKRsdIiJziHBtjkYqtcQJWLhv7eJ5AjiIYHc0jFNnwGxj+SHbt6lUamaB3pqbe nT2FN35g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUow-00000003VkV-3leC; Tue, 27 Oct 2026 00:13:42 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUov-00000003VjH-24dQ for kexec@lists.infradead.org; Tue, 27 Oct 2026 00:13:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E5834601F9; Tue, 27 Oct 2026 00:13:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96C671F01829; Tue, 27 Oct 2026 00:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793060020; bh=152UiJQPSd0WWhRV/RFm1y/NO86IHZgmxHUUAdsl+ps=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZRyUjmLKO6p0ajm1auFxv4ji+h3ZpFgw9G26JhXbCIZX8HX7qXp36SwEgggVVFmKv vKBhqOSmKsU8O5ihXgosnp7WZq8hLaoIGnjdzJU0rxubBqb05OCbCO/kN8wY+hPDhL 6l0ETjoc10eM5gJdwHodtu1vN9IsfI53ZFyimEOIoPQFPYYfeMj/4aBXRrRY7To8KN 2AZJ1YdnI7p3OqbivDYMZNhlkci3c2vK0D1yjJc3ErNtXZ9EUALKQGVyK1C4jKueqh H1q661lzNkebcTERMagaCqqPkVLvXKMTJVE/e35lvHmw+lA2h8+So3tJuaDxRG+q3g M606/DjuWl3Fg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 30/46] mm/mremap: recheck PUDs under the page table lock To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org In-Reply-To: <20261027-fixes_core-v1-30-6f74bec9a5bb@kernel.org> References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-30-6f74bec9a5bb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Oct 2026 00:13:37 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Once get_old_pud() is fixed to accept PUD leaves, unmap_mapping_range() c= an > clear a leaf between the lookup and the move. Holding mmap_lock in write > mode does not prevent this. >=20 > If the zap happens before move_page_tables() tests the entry, an empty > PUD can reach move_normal_pud(), where pud_populate() turns it into a > present page table entry. If it happens after the test, move_huge_pud() > can instead try to move an empty entry, triggering CONFIG_DEBUG_VM > warnings on powerpc. >=20 > Recheck the source under the page table lock in both helpers. Treat an > empty source in move_normal_pud() as a completed move, and use > __pud_trans_huge_lock() in move_huge_pud(). >=20 > In the future we should likely have the code lookup a PUD/PMD lockless > once, instead of multiple times, because one of the problematic bits > here is the: >=20 > pud_trans_huge(*old_pud) >=20 > Fixes: 0881ace292b6 ("mm/mremap: use pmd/pud_poplulate to update page tab= le entries") > Cc: stable@vger.kernel.org > Reviewed-by: Lorenzo Stoakes (ARM) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-fixes_core= -v1-0-6f74bec9a5bb@kernel.org?part=3D30