From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6E4606A31A for ; Tue, 27 Oct 2026 00:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uP9MM6Ag; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=QkmfWew/ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=RP9yy91n3owfnUZ5XWjIg1ghf2TsOgL/t0EJcRxXvSI=; b=uP9MM6AgcjN3T6mERYnFGS7Oq8 mk1ZBAZySe0D4au7n03E7VT05N2B2XQ2so8/MXAIJNezbp+YmQbmwD7iOV89zKuW+bbYFwvRn9xvV X8HReY4wxGsZMQHdNs61Nk9FEa0jRFzoPv0KYPz8o5frv9Ki6ukdHfLGMWAz0Hcv6dc1QQLED0VMg P8lHYczHYayhT77GHepwkLPFcSgTTlnfPT37QdtxFVq3AG7DONBW9lavGrsK2YKLEIwNNBGOZwAm8 ScbuQ2lbp99rHECe/GnwirU5FHDvB+0zZ8wWqt2PW0RO7jZgBZT2eigEPTNq86mX4E344lwuTJKME NCN26fkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUp6-00000003VsX-0piB; Tue, 27 Oct 2026 00:13:52 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLUp5-00000003Vqy-0V7B for kexec@lists.infradead.org; Tue, 27 Oct 2026 00:13:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CD60E40E59; Tue, 27 Oct 2026 00:13:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBD91F031E1; Tue, 27 Oct 2026 00:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793060030; bh=RP9yy91n3owfnUZ5XWjIg1ghf2TsOgL/t0EJcRxXvSI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QkmfWew/ADkm5Z3A+v4Wu1qzprJx11NFX++m/c9N1fTNuVpI106+XIHjNOJKc9B0m tInIdrA6fiRQUR/TvlJOIBitX3rw6fZ6/FcaSToKZMf1hPRLl7uttWxwVZywp7fnw1 5WQclAPrCh2/fZYnaLXu5L3kOi8qNeu5OT5CXehkRPLJ7ENmlIpAgRE66pGgFvHiZw kT5idC9a43tpR7kzlmod8qhPp83oRoM5i9XzIf7TKIsi4/qnD9jQubWZlWbfse6dZh GCHrshsGDKIppVgESabs2h6w5EQ/N4XLyxSNoDZOAG/6RUSjN34CjmqfPtvApWryjH bpEgtca8GshFA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 33/46] mm/madvise: fix data loss from MADV_FREE on a KSM page To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261027-fixes_core-v1-33-6f74bec9a5bb@kernel.org> References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-33-6f74bec9a5bb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Oct 2026 00:13:47 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > MADV_FREE can clear the dirty flag of a singly mapped KSM folio. The > folio remains in the stable tree and can gain new mappings without being > dirtied again. Once marked lazyfree, reclaim can discard data that those > mappings still need. >=20 > KSM always marks a folio dirty when converting it to a KSM folio in > try_to_merge_one_page(). Marking a folio lazyfree clears PG_swapbacked > but leaves PG_dirty unchanged. Preserving PG_dirty makes reclaim restore > PG_swapbacked instead of discarding the folio. This also protects folios > that were already lazyfree when KSM converted them. >=20 > Skip KSM folios before clearing their dirty flag, checking under the > folio lock to serialize with KSM conversion. >=20 > Fixes: 854e9ed09ded ("mm: support madvise(MADV_FREE)") > Cc: stable@vger.kernel.org > Reported-by: Josef Bacik > Reviewed-by: Lorenzo Stoakes (ARM) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-fixes_core= -v1-0-6f74bec9a5bb@kernel.org?part=3D33