Re: [PATCH v2] liveupdate: kho: calculate per-node bootmem sizes before allocating any

[sashiko-bot@kernel.org]

> From: George Guo <guodongtai@kylinos.cn>
> 
> kho_reserve_bootmem() calculated the per-node bootmem sizes inside the
> allocation loop, after the lowmem and global areas had been allocated.
> 
> Without CONFIG_NUMA, memblock_get_region_node() returns 0 for every
> region, and memblock_reserved_kern_size() attributes a region to a node
> by memblock_get_region_node(). Since allocations are marked
> MEMBLOCK_RSRV_KERN, the newly allocated lowmem and global areas enter
> node 0's baseline and are scaled again by bootmem_size_node().
> 
> In the original 1 GiB QEMU reproducer, the default 200% scale made
> node 0 request 672 MiB: twice the sum of the 98.45 MiB baseline and
> 224 MiB lowmem area, rounded up to 32 MiB alignment. The reservation
> failed and KHO disabled itself.
> [ ... ]
> Fixes: 3dc92c311498 ("kexec: add Kexec HandOver (KHO) generation helpers")
> Reported-by: Kexin Liu <liukexin@kylinos.cn>
> Co-developed-by: Kexin Liu <liukexin@kylinos.cn>
> Signed-off-by: Kexin Liu <liukexin@kylinos.cn>
> Signed-off-by: George Guo <guodongtai@kylinos.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029103425.14689-1-dongtai.guo@linux.dev?part=1