From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D58A606A31A for ; Fri, 30 Oct 2026 03:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kqvNkbY0; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ofyHQim0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=yv97JmgnR6ISRsZYALohwGoc1SQXA0bfBgRDcrydcQg=; b=kqvNkbY04RF2mxo+gvacO10Jlg MURsJXIcUSn3u5HpnVzWhJq965kU0OEJ+lz2ULTpPM0TocnnHtETyEGyWYA68Ypo0URheNcbShPMy Ch7pcbYri2nldxpo64Q/GAOVlMxldjWgckcgLgOLwEwZ8LoVp98RA5pDBfkGbPxWqSEQDzuNrX4hM 80PMJbsPjd1vG5/ZTDiZsxJii7sHlmqVOkmkEMtVUrCHnAHcZf9vgtnXjXdWsXj2/P9iQ0vfTSIzm 6ikJL3uxoA0+lh1l3hfrdKm35VK9cAS3UDwsszTk6OZIvrzjL56CoswaMQ/us0SFEPbLhUlFlwO7m CgDIw5Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdUc-0000000AkRS-0fLF; Fri, 30 Oct 2026 03:41:26 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdUa-0000000AkQn-1ovU for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:41:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 25FC34129B; Fri, 30 Oct 2026 03:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E8B81F000C1; Fri, 30 Oct 2026 03:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331684; bh=yv97JmgnR6ISRsZYALohwGoc1SQXA0bfBgRDcrydcQg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ofyHQim04HRxfLaenFhgFq9nP9Mqyd9Q3gq/v+2XMYQnLNQi0rN4xktP2sc9Z/6BF bKMtYY48bAxORxIIXVPBvZiThrG1k/GNWyx4CmeVkN5bWAPtPuf6XKupSrQXAfoJq+ 83AQANJNo7mzHnoJW7Xyu9SBhCO1fm9l1DvPVVbtfikTliLUCxDCpFkkuDuhnnPbWn Mui3zP+rpM9chDjc98RwNU5nt5FwZUNAEqrCLppy1hlOz4IzwyJVXlARU4a8mSauh0 7frBHKv1iqVXxqGIBP8kmRlLqBrez+S4dN7IVvEheO6BDLku+oGcBX828eMDMpsAX9 ov6FK2WiWbW+w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 22/47] mm/gup: check for overflow when converting nr_pages to bytes in GUP-fast To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org In-Reply-To: <20261029-fixes_core-v2-22-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-22-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:41:20 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > The overflow check in gup_fast_fallback() only covers the addition to > start. The preceding nr_pages << PAGE_SHIFT can already have truncated > the length on 32bit. >=20 > Users such as RapidIO's rio_dma_transfer() can derive such page counts > from a 64-bit userspace length. >=20 > Let's just check_shl_overflow() to reject any such overflow with > -EOVERFLOW early. >=20 > Fixes: c28b1fc70390 ("mm/gup: reorganize internal_get_user_pages_fast()") > Cc: stable@vger.kernel.org > Reviewed-by: Lorenzo Stoakes (ARM) > Acked-by: Muchun Song > Reviewed-by: Barry Song > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D22