From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F4B606A31C for ; Fri, 30 Oct 2026 03:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=drp6xfTn; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=A/ZaV2BD DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=qSNdCRCjnyh6nqAX4x4tusTbeJEr38DyrJSwit2Ah1M=; b=drp6xfTn2hTmUQzoqd+rP0ayhc EJ9ri0Zepgs0dKQRKlOwZG+L4qx2pvCVeOEQ79Lps2Mb3jSOWqBq0zbQY95RjutCNUpnUifF7wu8v HGm6vv1mn6CTzW26tNAZJnyyp9iQr2nqrD7fLQpc0vXSxIWeJsg9oks/Qkz+q6Wsu4IbMEzKOaF31 /FwbHj9ofjsBfbOUo2FKT40xHfOyYTd+MNOjr8x3w9h6IvhBJ6HAom0tT/woOOF734YpORPdy4pMB Z9oeMKvzlBOD8yEoMECkTha5/R2ORSAnOMkPNHw0x6YE2sSgi73RnoY2sCmAg1fKTBsXKzDCzurHG oOnifl0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdV0-0000000AkgV-3CTy; Fri, 30 Oct 2026 03:41:50 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdUx-0000000Aket-3N6m for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:41:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 264EB600C8; Fri, 30 Oct 2026 03:41:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C11F1F000C1; Fri, 30 Oct 2026 03:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331706; bh=qSNdCRCjnyh6nqAX4x4tusTbeJEr38DyrJSwit2Ah1M=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=A/ZaV2BDaKwsuv2tSwDw3+672R7XxntJb01FkDqXk0veJ8C5Ou+3+hvauChAeF4rS lPgieqmXICrFricUpYAM7hDaA3aUXD5MSoFtUjTuJ33wfVBeTrpz+s87a0bhTWexOj U++c3l/1RuNAW+e0LDV7Hpc0ii9H3ShpsCmrlkMVpL5lu/bflCRDePy0VvRXZY7LzP xeGyD+PuAzV2WeaNI/OogJTu5J04x0PHzxvigEPeGIAzNmk5PnFC4IdST0Si/Rx+WZ vqU0XwkXFCtCOicP/pHsEbI/48ufr+l/Ou5VYSdqXNHYJ5laWerFaILPY6H7i4Dqqg OO6EvEH2RSMsA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 29/47] mm/mmu_notifier: set ->mm only after mmgrab() To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Chris Mason" In-Reply-To: <20261029-fixes_core-v2-29-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-29-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:41:43 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Chris Mason >=20 > Radeon uses a non-NULL notifier->mm to decide whether to call > mmu_interval_notifier_remove() when freeing a buffer object. > __mmu_interval_notifier_insert() sets ->mm before validating the range, > so a wrapping userptr range can leave ->mm set after insertion fails. > Cleanup then tries to remove an unregistered notifier for which no mm > reference was acquired. >=20 > Set ->mm only after mmgrab(), once insertion can no longer fail. While > we could fix radeon's code instead, setting ->mm on success only makes > the code more robust. >=20 > Fix generated by an LLM and sent by Chris Mason in private. >=20 > Fixes: 3506ff69c3ec ("drm/radeon: use mmu_interval_notifier_insert") > Cc: stable@vger.kernel.org > Signed-off-by: Chris Mason > [ david: simplify description ] > Reviewed-by: Gregory Price (Meta) > Tested-by: Gregory Price (Meta) > Reviewed-by: Lorenzo Stoakes (ARM) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D29