From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6DF6606A31A for ; Fri, 30 Oct 2026 03:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2m5jDUsS; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Aod7EPH2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=P8qUj2Lyi9M5bEeQQEDKN13Kh3zQRbwq6uXOyQRSpCI=; b=2m5jDUsSUmWMasOEuHpmNUcSiz D4lnVBVehFRtS2b9BkMu56TVqNfKLVkweqb5RDmcvPRVd4/lv/JeLIQb+WNc9l6GCj6McQ1XeGaNx ajaXd1TkUQWCLmMRgxpA/cU1SpWZPvMOM6A0QloiggIpjOfG5g2b9WUcTAW8VPQWu77nf1g+sHtDD FLCekzUlvoHm85AM+dSamvuZRtbX/pGc2YqHO8dRfSGa5+3T1baXZjpJUsKZ80sHF37j8ZQauch/C 8tYHZsKkIs7xGmnXN47D/NGLeJHs5g1UfolT8ZWqZUDDVxIa5JRuzRIVeEFsts5jfNzIVvO02F2z+ jt3szkAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdVD-0000000Akps-2cUd; Fri, 30 Oct 2026 03:42:03 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdVC-0000000AkoQ-0dct for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:42:02 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 9555D600DA; Fri, 30 Oct 2026 03:42:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3A41F000C1; Fri, 30 Oct 2026 03:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331721; bh=P8qUj2Lyi9M5bEeQQEDKN13Kh3zQRbwq6uXOyQRSpCI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Aod7EPH2lEU2ehvHOvHCeEtpGs6ylV7AgyK9t9xzGFObYIyMuMQowD1+UZL+H9QxJ jxOrH7srMCrUb8p5x8IWegeeNSvjR4sYYEO9P+9Tjnxzwsh7FF9uAxF1+iYW393qpF g3bEPyDgc3y5/w+WqxI3J8SSCcfkglFyoXs/X5r5MZhZ180d/RpB2eYrInfspZUm/3 gCMqr/wPKmhy1wxUQGuOs62/gfFgq3xZxO0qmLkSo0N+lWLJvAV5fUTvyAGUYiB4bv 3fhSdEAO8U7cJCaRlLVCQ+hc3LeZ1ewCyvQlGXVIRwcCbwz936L2nL7JDjuRM/oOqW w5QXUAYdrQQaw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 33/47] mm/memory_hotplug: avoid races in pfn_to_online_page() with dying pgmap To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261029-fixes_core-v2-33-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-33-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:41:58 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Josef Bacik >=20 > If ZONE_DEVICE memory shares a memory section with ordinary memory, the > section is online and the pfns of the device are valid. > pfn_to_online_page() tells them apart by asking get_dev_pagemap() whether > the pfn belongs to a dev_pagemap. >=20 > get_dev_pagemap() only returns a dev_pagemap whose reference is alive. > memunmap_pages() kills the reference first, waits until all pages are > idle, and then removes the memmap. During all that time the function > finds nothing, and pfn_to_online_page() hands out the struct pages of the > device as if they were online memory. A pfn walker reads them while they > are poisoned and freed. >=20 > The entry in pgmap_array is only deleted after the pages have been > removed. Look at that instead of trying to get a reference. >=20 > This is probably not worth CCing stable. >=20 > Fix generated by an LLM and sent by Josef Bacik in private. >=20 > Fixes: 1f90a3477df3 ("mm: teach pfn_to_online_page() about ZONE_DEVICE se= ction collisions") > Signed-off-by: Josef Bacik > Reviewed-by: Gregory Price (Meta) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D33