From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1A7606A31A for ; Fri, 30 Oct 2026 03:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=u/ieVhYR; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=JA/cyb19 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=XTGfX6TBw9xJTGk7L+/sdxVTQMGPUJ3RAKj7h4jvHzY=; b=u/ieVhYRbEr+ConmTULL69aIA4 gTeOsXIIgwACg5Vv8tu7VQRJTegI0otQVBghPNqfUv4pSaLp4miqPrKsphGFYzYdJRvmUnLRugHs+ ZRFsNGAqbylaxlmtqmo+5ewBxHJWf43ycDYcLHgLM6zOENDeY1S+UEOIHpWse2Ze50iAqhhxIymAM qemM+3YP5UyFw+z9ynSfGFCNXi4xhij8sF/X1sXogyosfaS54AcZh4UGmxsouIz5DLcTi6vqSwW30 R7bgOG7MSwiKBSEDD9AMZuAuTtA3rixW1CiNSydTwq7Sm2D8e9QrCEklNg29oC5MEUefcTBBI0HbW ZA/EA9xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdVt-0000000AlP4-2DvT; Fri, 30 Oct 2026 03:42:45 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdVr-0000000AlNd-3snF for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:42:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A935B415F7; Fri, 30 Oct 2026 03:42:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB121F0093A; Fri, 30 Oct 2026 03:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331763; bh=XTGfX6TBw9xJTGk7L+/sdxVTQMGPUJ3RAKj7h4jvHzY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JA/cyb19Dc3SKC5g7+GzH7no8zlWDajPO3SccHX8CLpTX4n+Cbi37DqrDBy0RAkDx 7GacHwZ3KNE3yDP0zrJ6/uvD6iCbgGWJJnrxEYT61jPbDbl5UQwXeAMSfZQPFBOfTa tdyZoMwLHMMf+e8u7lRe8EloBwx9RIVWIPxBfPPpVKNR1+Yxtr6MFhslT58VHP94nH eK20+xXY3bglH4wmEiXzz8y5rLtP+hp0JYSf00UJ0oLB+OSiikBUiHffZGKLO7ojLE 9Nkp74/667emjDkanYliQhdzCUxhiLyjLIVzWpw50crbREx2QBXu6SEam0A3NhuGoF T3XUtWx2FK+XA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 46/47] mm/memory-tiers: unregister empty tiers outside memory_tier_lock To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261029-fixes_core-v2-46-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-46-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:42:40 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > When offlining a node's last memory empties its tier, > clear_node_memory_tier() calls device_unregister() while holding > memory_tier_lock. A concurrent sysfs read can hold a kernfs active > reference and block in nodelist_show() on that mutex. device_unregister() > then waits in kernfs_drain() for the read to finish and release its active > reference, while the reader waits for the offlining task to release the > mutex. >=20 > Return the node's former tier from clear_node_memory_tier(), making the > helper more similar to set_node_memory_tier(), which also returns a > memory_tier pointer. Let the caller unlink an empty tier under > memory_tier_lock before rebuilding demotion targets, then unregister its > device after dropping the lock. >=20 > Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs") > Cc: stable@vger.kernel.org > Reported-by: Josef Bacik > Reviewed-by: Gregory Price (Meta) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D46