From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD1A606B26A for ; Tue, 3 Nov 2026 14:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=et7geGAY; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LYcaZ7np DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=a7PYmXCvRfg0BwzdfEGz44ga4Pu8BO8P1McRUIl/QmE=; b=et7geGAYB8DzPBQb4rXJPvf/Ss lmsXF1OeWV/MyvkZlpJYMqQwammwiI5LbAff8ywyrfav5CqLXz45wQEReOGe7oyrT0kqco/uFS0jR KGfAs62RqioPQlnmwR2pDur5WD3iOCkGF5H1EVtMNTbkTaN0ExiJedJIDcDMRCax/NJnCkFDMiyWn W4p+jHqzASLlTN78h4tVvBF6/iqvxk9EoEWhyv8y5RLV+4pFPV2DNAU0OtAYpd3X1wRvn0EUynidy IiobatZ24kHXJailce4mppdVsUCX2yA/bwug0UkO3YXD6P4d+mUnnPpxUIpXWQKIAIPjaBxV7+vVp 0DeM+VGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOFoI-00000002lXF-3t96; Tue, 03 Nov 2026 14:48:26 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOFoA-00000002lP4-41mV for kexec@lists.infradead.org; Tue, 03 Nov 2026 14:48:18 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A046E43C89; Tue, 3 Nov 2026 14:48:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 308B61F00919; Tue, 3 Nov 2026 14:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793717298; bh=a7PYmXCvRfg0BwzdfEGz44ga4Pu8BO8P1McRUIl/QmE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=LYcaZ7npTHcFZjRzH7+Fn7MvhHCtX0Mfq+N7asGR7lT4O/D1juNNOdkQoItQPXgYp izFBnUx2NnP6oS7/UFWY3ZtlEiHQGAb8tqYNXHfwpj3k+q8UhKlx3Y4Pg97Y/XyE6C xkIjNo0WOFg/e5GUKQx1UXiaj6PoeUJ8Rmrh0A+WWO6gWPU/v7hy2cXWYqJOtZ4R1f AJe7tJP3tO80byckeYCg7WXwCIl/UiBUMp8jrZdTJOebfpv8qtOWQYXX6ex20nPx2Q aG3CJ/kyI5aKfpxI+HIjIsP6p5FlMEL6CTbtmCCpK2w8UzCSgTGpCSlE70jaIGX3Vm wS/Yy4/2pHR0Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 25/38] powerpc/crash_dump: check ioremap_cache() in copy_oldmem_page() To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-bugfixes-v1-25-59422ed3e465@kernel.org> References: <20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org> <20261102-work-procfs-bugfixes-v1-25-59422ed3e465@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 14:48:16 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > copy_oldmem_page() maps a page of the old kernel that isn't in the > linear mapping with ioremap_cache() and copies from it without checking > whether the mapping worked. If it didn't, the copy reads from an offset > into the NULL page. That oopses unless the copy happens to be a user > copy, whose exception table entries turn the fault into a short copy. >=20 > Return -ENOMEM like the other architectures do. read_from_oldmem() > turns that into -EFAULT like any other short copy. >=20 > Reported-by: Chris Mason > Fixes: 54c32021eb6f ("[PATCH] powerpc: Add arch-dependent copy_oldmem_pag= e") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-bugfixes-v1-0-59422ed3e465@kernel.org?part=3D25