From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8864606A7BA for ; Tue, 3 Nov 2026 15:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=DGQ2a3cq; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=JZfT8cxp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=1669At5pGJiRDZ9q9xSvM+3vv7+5NMnsw09fzaDlx10=; b=DGQ2a3cqBM+g7VhF0ZXtVGd5ME I1iEyICl+NENhCSQJR9mHhihXh/1rAIv53+nUjyC8nmXfKbWz9bZCmhCDHT0pz/pqlbBiY3G5tIGh ooVYXwJyb4OjsMuD67Q4cB+ZFm//3KfoOd+8SNqN6/NsTzoMjELoxYdZFHloGb3t84kKjoNNblEiW KcClUdQQaGTD1IhKZAFwYNyXpYm/ATz8wOuGbPiZZe55zCUGMEpFrEFoKULZymN+EOk3eyB45B5nL /BSyLMp0JNzHKYA0hswo6teahOYxWo23eNaOUxcNNWPdROYDOk2DdCOZqZpJ/NP4mGSIXy/A2J0VR td0a5T/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOGIH-00000002vsp-1hEq; Tue, 03 Nov 2026 15:19:25 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOGI0-00000002vUG-0WQG for kexec@lists.infradead.org; Tue, 03 Nov 2026 15:19:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BF6CF414E9; Tue, 3 Nov 2026 15:19:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F4961F00A15; Tue, 3 Nov 2026 15:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793719147; bh=1669At5pGJiRDZ9q9xSvM+3vv7+5NMnsw09fzaDlx10=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JZfT8cxpUtmS3Kfu8V8PLYWnJuG3QySVD8DWoG504UE/BwxXpC7dHd7PKrOTZWHmz I6RJLz9S/hhhp8+eQpZpz+oEIOWxmfWCL4bx500g2aQ1hg05iA/9HRVNHvNFfHL/Lu tBIfPhSNRR3m+YTao2Y3H12toeLC5vMYzC3SZN6bbXZOKGGZmByWURolhYAfLYTvaz zimX68IlrTRwQB5vLHbS+EwZ3rJnfI2C495z2dd+hJXKtSlWsTPyKeCr1H7ROdmD8w jA4rMhtSMKdq7Fq20Y5PzuwGOJlfb0TFWxTgVxa0smDFU7J4nuTjB+0C0F7Qu3VQJT 86sM7gi4iXHYQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 19/23] tty: sysrq: let procfs copy in writes to /proc/sysrq-trigger To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-drivers-v1-19-a994bd4d3b1a@kernel.org> References: <20261102-work-procfs-drivers-v1-0-a994bd4d3b1a@kernel.org> <20261102-work-procfs-drivers-v1-19-a994bd4d3b1a@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 15:19:05 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Implement ->proc_write_buf() so procfs copies in what is written before > it pins the entry, and handle the keys from that copy. Writes larger > than PAGE_SIZE - 1 bytes fail with -EINVAL now. They used to trigger the > first key, or all of them in bulk mode. procfs allocates the copy, which > is as small as the write, opening the file allocated as much already. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-drivers-v1-0-a994bd4d3b1a@kernel.org?part=3D19