From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193CC606A31B for ; Wed, 4 Nov 2026 01:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QBRrGiu6; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jKNHYWtf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=VjQj72weLtRUEeeA7pEXpvTgVlPTwRiBgG+W6jPCuAk=; b=QBRrGiu6k2Dsk5ilFThIYkUGCR 3UQzcNCf3Ezf0oyyJGkH5lNLlmA1my+apodE9UdDmROQ9PqvpoHCEfjDo5SrTaveJiCKWqRNoPV+/ THD+lsRWO5hEKRmzSPkWLqSOoCyX22olhSYQ1bWeMfvugiUh9fnwbPTzsp252L3MdZpYiCA0krknz xEWkF6IHEsuUBbC3vN9uo7cVJIEBG/s9WIa6vUyIZer+m1hbXkE6Od/PZ0W4kvJoNr7VZRHPpmLbj HQ0KAT2G/TAFYoRc6pzIvz12Za1VTkb//xB52E+t/LrHnusxV465kCls0ZXV7sXKssXsfAYqpcC1H oSFLZ2gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOPPX-000000042O1-3QHg; Wed, 04 Nov 2026 01:03:31 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOPPV-000000042Kx-2byR for kexec@lists.infradead.org; Wed, 04 Nov 2026 01:03:29 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 02B7E43995; Wed, 4 Nov 2026 01:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0E141F00919; Wed, 4 Nov 2026 01:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793754208; bh=VjQj72weLtRUEeeA7pEXpvTgVlPTwRiBgG+W6jPCuAk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=jKNHYWtfvxIENEJmYuKJVD82YnLLgeQU/XLqdGMXg9IPKe+FrOAPTOy+YK7dMezJW LnpMR6qCjSyv0/0F4Ouun2kcLvSIUikEqaZGIvFNrZvtOkqflsv4d/zgkE9A2TuvuI o5fIOw7tl+nP447L4/68IFSh8aiXAP9QGR893g8Djq4bxjpDoRmp0tFOjb/OvJGYlB ebMFsalym2S7/ZusnUKOTe8TbMcEosVqwLp0ypT6PNgE+s2LgDoRhgjJVAueOS6nUU t3JlmWaOV9grDiYuXXm7+lcSTHQ47aMW3BxVZM/q0r5/3X5iWBKHieIPVHuG8z1r/i /3kgPw6nuTO9w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 05/10] liveupdate: Don't WARN if tracking a retrieved file fails To: "David Matlack" , kexec@lists.infradead.org Cc: "Alexander Graf" , "Andrew Morton" , "Baolin Wang" , "Christian Brauner" , "David Hildenbrand" , "Hugh Dickins" , "Jonathan Corbet" , "Liam R. Howlett" , "Lorenzo Stoakes" , "Michal Hocko" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Randy Dunlap" , "Samiullah Khawaja" , "Shuah Khan" , "Suren Baghdasaryan" , "Vlastimil Babka" In-Reply-To: <20261103010216.3447716-6-dmatlack@google.com> References: <20261103010216.3447716-1-dmatlack@google.com> <20261103010216.3447716-6-dmatlack@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 04 Nov 2026 01:03:27 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Handle a failure to add a retrieved file to luo_preserved_files instead > of triggering a WARN_ON(). Make the failure permanent, and keep the file > until the file set is finished, like any other retrieved file. >=20 > xa_insert() can fail with -ENOMEM, and userspace can trigger that with > LIVEUPDATE_SESSION_RETRIEVE_FD, so warning about it lets userspace crash > systems with panic_on_warn. >=20 > The handler has already consumed the preserved state when this happens, > so the retrieve can't be retried. Keeping the file ensures that its > resources are not released before the file set is finished. Finishing > the file set then erases the file from luo_preserved_files, which does > nothing for a file that was never added. >=20 > Fixes: 00d0b372374f ("liveupdate: prevent double management of files") > Signed-off-by: David Matlack Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261103010216.3447= 716-1-dmatlack@google.com?part=3D5