From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73497606A328 for ; Thu, 5 Nov 2026 20:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ngQkDfHj; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=MJtgcSMf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Ru/qyz255iW10fX/xYGvqKwjOThmYmiF9XoSZGKM7R0=; b=ngQkDfHjimdsWFv9i5GnXihyBm A6g/U6ZU7GPPvhCWW9IQdWSYx9rxTHJiKpNrXH4/lQq6UVJf38vqGY6E6RojYaynU3kFOTQC1ypAu zncGaXQIxixCJEVH2S13+fY+B+6T0Ir6FdcfDgguhOgwFXtFG/idTH2up0KgMY6jd7NCgnDrO2EYU FZoIw0+4m6NqWNklASKFuJG9bv2tYuK3a+AGDYF8NhMa8wgUiLAiqssHhJP9PrlzwS2qU5B8fAHGp grQevhSip9EjstLEnYD+XBwEC9zMcoLYpfV41HWx4B+4jzCp+/CXlDVYDqBRWzKumFMPDJgsGzWcV pkmH4eew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3BK-0000000ALEO-3bCE; Thu, 05 Nov 2026 19:31:30 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP39k-0000000AKY1-0gY7 for kexec@lists.infradead.org; Thu, 05 Nov 2026 19:29:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 994A6601D8; Thu, 5 Nov 2026 19:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C5C1F00A17; Thu, 5 Nov 2026 19:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793906991; bh=Ru/qyz255iW10fX/xYGvqKwjOThmYmiF9XoSZGKM7R0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MJtgcSMfLpnK3zQ8ve5AytNoGwVGMCdIK3G/+WxnM1JzzDcQ8DAnN5v4DQpZqVkNE JIFRqjboUyRPr1h1Dl1DKUbwP7QphpfK/YvUU9TIXGy/tTS0d+xdV2MLivsLV8Dgu4 UzSkOJsM/jDsL0ZM5k9XUlcPM1VkW2J4kRWeL7ktokcrjcRTTBioEI2YpgLZh5eP7W u6bhsGA2WwPT6st0KQcgRf2kcMXrl5bjJKLXx/8iPS2CkkO8y5/gPDeqZL10iGDxGi ryctgUStVMh1y8vZQVQju8TMtjpBqM9jPCUp5nhZiIt7GtigUzscvBis/aL4RTjcOy LOwDNub5ShbCw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 31/51] proc: don't WARN about a name that is already registered To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-bugfixes-v2-31-021c84d852e0@kernel.org> References: <20261104-work-procfs-bugfixes-v2-0-021c84d852e0@kernel.org> <20261104-work-procfs-bugfixes-v2-31-021c84d852e0@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:29:49 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > proc_register() WARNs when the directory already has an entry of the > same name and fails the registration. Callers that pick their names > themselves should never get there but some take names from userspace. > pktgen creates a file for each device a writer of "add_device" adds, > named after the device. A device can have any name, including "pgctrl" > or "kpktgend_0", the names of pktgen's own files: >=20 > ip link set lo name pgctrl > ip link set pgctrl up > echo "add_device pgctrl" > /proc/net/pktgen/kpktgend_0 >=20 > proc_dir_entry 'pktgen/pgctrl' already registered > WARNING: fs/proc/generic.c:404 at proc_register+0x555/0x8b0, CPU#0: bas= h/241 > Call Trace: > proc_create_data+0x9f/0xf0 > [ ... ] >=20 > Reported-by: Chris Mason > Fixes: 6c2f91e077f1 ("proc: use WARN() rather than printk+backtrace") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-bugfixes-v2-0-021c84d852e0@kernel.org?part=3D31