From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8C7606D812 for ; Thu, 5 Nov 2026 20:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Yr7ke3Fz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=icO3rWLw DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=QnupmpJjcDSUenY+8iHhV2pDdP26FR+grPEd9BKN+Wg=; b=Yr7ke3FzJ0tWPiyi5knRRx3Z/U loc1Q3s72z2kPyxjNXBw+6mupiONkDPd8WnqG7PkFw9P4z4NoP6eN2gJSveQbSfF3Z+wdOvESdzWT L6MtbZnAKUwH2S0vF220DQsrq2VHBlMZaQrcTsx1vxqdGsFHDqDK6Kg7yHtF2M/5wqsaq8u6efVeA nhqpoah+7aO4OzR9r2C11eDZFkZbyObTtB1d9UUmTcbXjKP5ONXkbrTPeSSH817eMl3Fx8jAnY5dS 0PUnzBWbDMVG8N45YgsQ3I2tJmshrhbeDrjejmHhm2KLAERFpoWnOQ0B3Ze3CBqmkHmRVo+54vNlk iHJWwFDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3Fg-0000000AN56-43pf; Thu, 05 Nov 2026 19:36:02 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3FE-0000000AMrE-0OfL for kexec@lists.infradead.org; Thu, 05 Nov 2026 19:35:32 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B12BC43B0A; Thu, 5 Nov 2026 19:35:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E09C1F008A1; Thu, 5 Nov 2026 19:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793907331; bh=QnupmpJjcDSUenY+8iHhV2pDdP26FR+grPEd9BKN+Wg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=icO3rWLw6nKGObCQJgYMxAh2P6PTRzIdDeuA404d8zGUUVnEp22awIUt/ONskepjG FQyNYgueaW+0iYJhp0FqJ+XOW2y+yurI0uUuh+dfsOclM2Nh3qdwIC3ytuTEQmNhzr MTetr7AbbAQJrQhhBXugv5fx//leXY88njWHb3TZ3743y/bVbrU4sQkjQK81piouKz MGYh6ZeJ6sFNsrOgjNWWNWno+Xud511eRRatEpGCbh1xHAr4ri1vGAQGPMtUR0YyMD sstDXtwDG9/n6Jsu5U178yWJP4hODLvoqYoWfkpM7RkF01wue3ewhl7sYNSjaz7bA6 sSwHZw/oTnT7A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 08/23] proc: let procfs own the seq_file of proc_create_seq() and friends To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, dmitry.torokhov@gmail.com, "Petr Pavlu" , "Anna Schumaker" , yukuai@fygo.io, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-core-v2-8-76ace653a773@kernel.org> References: <20261104-work-procfs-core-v2-0-76ace653a773@kernel.org> <20261104-work-procfs-core-v2-8-76ace653a773@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:35:29 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] proc: unused-but-set variable p in seq_open_net() when CONFIG_NET_N= S=3Dn -- commit 4dea51dab83a49a4131e34ad5f96bc9822052389 Author: Christian Brauner proc: let procfs own the seq_file of proc_create_seq() and friends This commit updates proc_create_seq_private(), proc_create_single_data(), a= nd their network namespace variants so that procfs owns the seq_file directly = via PROC_ENTRY_proc_seq_ops and PROC_ENTRY_proc_show. For the network namespace variants, ->proc_open() and ->proc_release() are simplified to only manage = the network namespace reference. > diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c > index df5484813d5dd..9973f846c4674 100644 > --- a/fs/proc/proc_net.c > +++ b/fs/proc/proc_net.c > @@ -37,13 +37,13 @@ static struct net *get_proc_net(const struct inode *i= node) > return maybe_get_net(PDE_NET(PDE(inode))); > } > =20 > +/* procfs opened the seq_file and allocated its state, see pde_seq_start= () */ > static int seq_open_net(struct inode *inode, struct file *file) > { > - unsigned int state_size =3D PDE(inode)->state_size; > - struct seq_net_private *p; > + struct seq_net_private *p =3D ((struct seq_file *)file->private_data)->= private; > struct net *net; > =20 > - WARN_ON_ONCE(state_size < sizeof(*p)); > + WARN_ON_ONCE(PDE(inode)->state_size < sizeof(*p)); > =20 > if (file->f_mode & FMODE_WRITE && !PDE(inode)->write) > return -EACCES; > @@ -51,12 +51,6 @@ static int seq_open_net(struct inode *inode, struct fi= le *file) > net =3D get_proc_net(inode); > if (!net) > return -ENXIO; > - > - p =3D __seq_open_private(file, PDE(inode)->seq_ops, state_size); > - if (!p) { > - put_net(net); > - return -ENOMEM; > - } > #ifdef CONFIG_NET_NS > p->net =3D net; > netns_tracker_alloc(net, &p->ns_tracker, GFP_KERNEL); [Severity: Low] When CONFIG_NET_NS is disabled, does initializing p unconditionally in seq_open_net() trigger a -Wunused-but-set-variable warning? Previously, p was assigned via __seq_open_private() and checked with if (!p) outside the #ifdef CONFIG_NET_NS block. With that check removed, the only remaining reference outside #ifdef CONFIG_NET_NS is sizeof(*p) in WARN_ON_ONCE(), which is an unevaluated context and does not read the value= of p. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-core-v2-0-76ace653a773@kernel.org?part=3D8