From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B4B606A6D8 for ; Thu, 5 Nov 2026 19:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HR2Pfly1; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aBpWIN4H DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=wcOgF6I0KZL3tk97PgTaU7xCFlwNk82oM8K3Yy+AHys=; b=HR2Pfly1lAzUTNVcrgWSXCEbyK JxArZeg+B1Ps7EaU3B+sdBla3QAQ0Re0dvC4Oz55KZ9nZNau8BEcDPzfFQoJ86ubyIDMmFypOD5gp i/1Sgk7wgccW7zGhQe6kGMiKfHeo52/KIsCjC2E9DAg+xwP+T0uuIVI2xytswIHZlaFxkX7oSHv7s zM9d5b9bhKgjxz1XkhcmMrseh3LSsLSub4mrHe5L8FGKwzLMNgWhxg/C5dmQZr0M5oONC0EDbaI+l r6tOvr3peOn6CkdFFFh8DAtjh7D7sKSplx/Igw21d+0uZPb5GdCmToNAeKVHOsfBq0RBk1X17j3ub tqNg340g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3UU-0000000AQVK-0503; Thu, 05 Nov 2026 19:51:18 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3T5-0000000AQ05-2Xjs for kexec@lists.infradead.org; Thu, 05 Nov 2026 19:49:54 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5C818444EF; Thu, 5 Nov 2026 19:49:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFBCE1F0089F; Thu, 5 Nov 2026 19:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793908191; bh=wcOgF6I0KZL3tk97PgTaU7xCFlwNk82oM8K3Yy+AHys=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=aBpWIN4H+IPXlAf4uhQaT4gTnkT8RNUC+7KT0a19CGAzuyrH2d/d5QNIzOsDfREmP OHKxJk5tkuz5k4DgXe7Wh5+1+7YWuRYhCjC2WLPI4T02sD3XGSQ7JvmzEGX7Id003S qr+pMLJ3DE26ABn/dOtypdvXbUSh/97Bq/1VIZT+pjFsEp35N5jpaqxjwMn/jnbhOE R2p5HLaB3AYWWLOynqVOowHnGoXOtdUD2DZVMSB/CNWgILqXfvQFedtAWyoFjZDWQk o2a9Hsr2lNnZH4Uzfq7jkIJjVPvL/wlCIvzLWMQ9KqbzHH+jIPNP6nT3AVZrusCM3J Mh6j2wX7Eo8Pw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 20/26] tty: sysrq: let procfs copy in writes to /proc/sysrq-trigger To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , "Jiri Slaby" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-drivers-v2-20-245e54e87116@kernel.org> References: <20261104-work-procfs-drivers-v2-0-245e54e87116@kernel.org> <20261104-work-procfs-drivers-v2-20-245e54e87116@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:49:49 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Implement ->proc_write_buf() so procfs copies in what is written before > it pins the entry, and handle the keys from that copy. Writes larger > than PAGE_SIZE - 1 bytes fail with -EINVAL now. They used to trigger the > first key, or all of them in bulk mode. procfs allocates the copy, which > is as small as the write, opening the file allocated as much already. >=20 > Reviewed-by: Jiri Slaby > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-drivers-v2-0-245e54e87116@kernel.org?part=3D20