From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5C70606A6C9 for ; Thu, 5 Nov 2026 19:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zytu/251; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BiP3vWa5 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=mJTbTSNaksdvlnijZLFCGOr4psTGJIHnmxgFlkDd4gI=; b=zytu/251YV/+Qkqh0xLtyTLR0I mmVO2lMs0TZ56AEX+6cGJsdQuHIozlkroBZjaycjOQPlnYbiSqnmwFiJw8QIW4xoEpkIyb04lfdyD Dg7lOUJGX37Y9ygiVY3pBzbw4zxJb3gjwERZAZKtxYOdFtubKw6+XPgMyi2HPysWusRvTkt/YSTpC mQhM6e5S7SK4GqWpF8YvJs/q1/thynCU11QOx3fLhkrYXJRmePkhGpzLcvhQSDwAo63j9Zo5zcaxL mKAobklxXTD06F9kwoOgjb1m4lrp4JqZ7v69G3T55j2Zlj6E5SRLdqZ4s0O+2twZg9Ch1o4258JiT JlwKAFQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3Un-0000000AQgJ-0xle; Thu, 05 Nov 2026 19:51:37 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xP3TD-0000000AQ88-45cK for kexec@lists.infradead.org; Thu, 05 Nov 2026 19:50:02 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B7ADF42D52; Thu, 5 Nov 2026 19:49:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D4531F0089F; Thu, 5 Nov 2026 19:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793908199; bh=mJTbTSNaksdvlnijZLFCGOr4psTGJIHnmxgFlkDd4gI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BiP3vWa5C7VCqt3Apwn3UEuoadJLOFVATCUGY/TCkjTG6EioUj7msFuDm+u6S80/v F/ovWS0/vbG4NoPvX3oaC4Ju6kOgutrh42xA82zotUqEKnnIjJM8ubgYbG3hMNjSXM Swiblg6S0THlNhJQxthAwOda244CN8fXsj3HotdqSR0fAud3TJ7au54xUuBJ8QVgNK I5516bErhTjW+BnoKXFgRN3a76QQkuKdwJlNjT9I9qk0/OjcS7X9lfr0QyejL4LM2h sFNh7YOripcN6NumdxOyC3c7UON5Z1tyyMYNW5N1EuFPeMdzK1EbeZGlbAlbQ0aysz NQ51S20K/BX4Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 24/26] ALSA: info: let procfs copy out reads of data entries To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-drivers-v2-24-245e54e87116@kernel.org> References: <20261104-work-procfs-drivers-v2-0-245e54e87116@kernel.org> <20261104-work-procfs-drivers-v2-24-245e54e87116@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:49:57 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Implement ->proc_read_buf() for data entries so procfs copies what is > read to userspace after it unpinned the entry. ->read() of struct > snd_info_entry_ops fills procfs' buffer now. opl4 reads the sample > memory into it without a vmalloc() buffer of its own, gus, cs46xx, > emu10k1, scarlett2, cs4281 and mixart copy into it instead of to > userspace. The driver guide still told raw callbacks to copy to and from > userspace, so update its example as well. Data entries ask for > PROC_ENTRY_FULL_READS so that reading all of an entry at once keeps > working. A read that faults on its buffer in a later piece returns the > pieces before it now instead of failing with -EFAULT. >=20 > Unbinding a card then no longer waits for a reader that faults on its > buffer. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-drivers-v2-0-245e54e87116@kernel.org?part=3D24