From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 106B260A2601 for ; Wed, 11 Nov 2026 06:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=O4+qryJa; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Wc+xg9hT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=jmri/3hIXC1hkulfS1LbY1DwiOs1O/U8k06v0LuYAfU=; b=O4+qryJaQGCHlHpf084WlHZuFj qyNMjIxz0mZ5hOqMxIsQB4EQP8VHVK32PDYoisKUZMiz3PcNJt92fQFwmZr/FKnX61NlwJRWKAQ5S zgQsCwF2S3N+0xvds/tKmCILLItC8xT5dwAVOabIc6KAGPKLghagHdyzZ4WfCer1v9j4tPWtRE4HL fspJt1ooHOiTJbQWvfgqvNxBjxvfQYzStFFmHXQsimOjAIPRGObNiXd9eXksyEEybozhqaePk/6Ip 6EJqdJ+ZCXITQRDeNMwsd2KdHI05ps0gpnfw9pULr1BJwr5ZLWQsGoemkQRj+DV6mBpnY9LOe571A mldqf2zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR1dR-00000005j4D-343K; Wed, 11 Nov 2026 06:16:41 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR1dO-00000005j0g-2xqn for kexec@lists.infradead.org; Wed, 11 Nov 2026 06:16:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 27B3B61CD0; Wed, 11 Nov 2026 06:16:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91BDA1F00A06; Wed, 11 Nov 2026 06:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794377797; bh=jmri/3hIXC1hkulfS1LbY1DwiOs1O/U8k06v0LuYAfU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Wc+xg9hT5y5WkcAg7unw4Vgvrn/WaES8C73CCGxuxj62uYfJ1ys2T7cn5dPN8lKzE xEtbc3Fb2BGBrqVohk2iEVY+3ybuyvy9FWLfn51iM6XNXvJo9WbaF2imxSV/wCg5IZ 8z2eQoaHPSi26C1lVj1HXoeUOWo6JdJQgdDeaDEHuWe3sLEynXVF0A8wd2Hopo/Jf2 Js4nOEdzoS20+4EeegSi1oTgmOMaVgLBBabJwy9g4QcSuI+mHY1w2ALylp6hGgulzu kE5e/Lgc923grLjIIX5wGwxLnJbCx9hDh09o8twSuIsbp4HOvqv1zzRbOr+aRB8aSg VZo29WtpQkF3Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 06/19] kho: kexec_metadata: Add the feature header To: "Tarun Sahu" , "Pasha Tatashin" , "Mike Rapoport" , robin.murphy@arm.com, maz@kernel.org, will@kernel.org, "David Matlack" , "Alexander Graf" , seanjc@google.com, jgg@nvidia.com, loganodell@google.com, arnd@arndb.de, dwmw2@infradead.org, baolu.lu@linux.intel.com, "Bjorn Helgaas" , oupton@kernel.org, alex@shazbot.org, gle.com@google.com, pbonzini@redhat.com, "Andrew Morton" , kevin.tian@intel.com, joro@8bytes.org Cc: linux-pci@vger.kernel.org, "Pratyush Yadav" , kexec@lists.infradead.org, skhawaja@google.com, sagis@google.com In-Reply-To: <20261110050202.529473-7-tarunsahu@google.com> References: <20261110050202.529473-1-tarunsahu@google.com> <20261110050202.529473-7-tarunsahu@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 11 Nov 2026 06:16:36 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > The kexec metadata subtree currently uses a monolithic u32 version field > to identify the metadata structure layout. Any change to the structure, > even an optional additive field, requires incrementing the version and > breaks compatibility between adjacent kernels. >=20 > Replace the u32 version field in struct kho_kexec_metadata with > struct kho_ser_hdr using DECLARE_KHO_SER. Later fields can be appended > under new feature indices without breaking compatibility across kexec. > Also make the 3-byte padding hole between previous_release and kexec_count > explicit as reserved[3]. >=20 > During deserialization, validate the blob size against the header size > and reject unknown required features. A legacy v1 metadata blob is > ignored with a warning. >=20 > Signed-off-by: Tarun Sahu Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110050202.5294= 73-1-tarunsahu@google.com?part=3D6