From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB69606A31C for ; Thu, 12 Nov 2026 00:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fHPwG28C; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nDdzVZ0U DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=+RKCsSPMl4PMcPUQbOvAbSh01jiFe/xUeKSVXxo5E40=; b=fHPwG28C4kL2jD5yQU1tnP7RyH Do743WJNpGCP2tcdajJkmYKaP63+LVxlRUuJCvUQsIEnxcsc+Gg6kLQLe11uIbEfCBoON1U450vXZ SCWoKCPR8oXww6RjiwG6dShU2olCx7tt1dwLuQIZsVk5FSnME4FAEa2b6L2XRIBBopzWYHTEPPtLB o9N8dbQV6J1ajtNHBr+iREmTDB7qPEPvhfAJ76MZZrRtKBy/cN/5NzOqtbjfPcZkMtT00ID7ZxYma JWpOrkc1KfatA+DJt5hikSHcZEf/pMj7xoAUMe9Skd7Iybeb5a2LguOvsDtZ/PfI+LQYonAMc8MkF XCoL/IHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRIig-00000008F6b-0gpr; Thu, 12 Nov 2026 00:31:14 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRIic-00000008F2W-0gJz for kexec@lists.infradead.org; Thu, 12 Nov 2026 00:31:10 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E537743288; Thu, 12 Nov 2026 00:31:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6D0F1F00A05; Thu, 12 Nov 2026 00:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794443469; bh=+RKCsSPMl4PMcPUQbOvAbSh01jiFe/xUeKSVXxo5E40=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nDdzVZ0Ur0fRI1VsYSG/JXT4lejqqML+EyztEbSy7VHqc28mQImF7FouvBO3Ywpie QIZWJN1aYfnoNoPpBw878uVX9BdqBVML5d25OK63y3azvZ01Eq1ij4urClYhMuAOna JjtVgXde1xkC7irGlwHq+Docm5RFHnabN/Qf3H2YTCUexrKCLf8TAeIr1J8hgJ39fe DWtQKC0XH8WjEFp5S69thBROipGL65p0T1/NSMDnhBiUwlDshXxmPnXmtmEwO91auh nKm55ud3bduNwO6Wrur+qlm4jYYHixLhT8PrTyJQ52yxozoH7V/feuPyih4yoAn1en emqicgOqdKoag== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 04/19] liveupdate: Allow file handlers to mark retrieve failures as retryable To: "David Matlack" , kexec@lists.infradead.org Cc: "Alexander Graf" , "Andrew Morton" , "Baolin Wang" , "Christian Brauner" , "David Hildenbrand" , "Hugh Dickins" , "Jonathan Corbet" , "Liam R. Howlett" , "Lorenzo Stoakes" , "Michal Hocko" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Randy Dunlap" , "Samiullah Khawaja" , "Shuah Khan" , "Suren Baghdasaryan" , "Vlastimil Babka" In-Reply-To: <20261111002358.1842967-5-dmatlack@google.com> References: <20261111002358.1842967-1-dmatlack@google.com> <20261111002358.1842967-5-dmatlack@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 12 Nov 2026 00:31:08 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Pasha Tatashin >=20 > Add a retryable output flag to struct liveupdate_file_op_args, which a > handler's .retrieve() can set on error to tell LUO that it hasn't > consumed the preserved state. LUO then lets userspace retry the > retrieve, and .finish() still releases the preserved state if the file > is never retrieved. >=20 > When luo_retrieve_file() invokes a handler's .retrieve() callback and it > returns an error, LUO currently records the error in > luo_file->retrieve_status and blocks any subsequent retrieve attempts. > This is necessary when the handler has already partially consumed or > freed the preserved KHO state. >=20 > However, with user arguments passed to .retrieve(), a handler may fail > early while validating caller-supplied parameters, such as a missing or > invalid argument, before touching any preserved KHO state. In such > cases, userspace should be able to fix the argument and retry > LIVEUPDATE_SESSION_RETRIEVE_FD. >=20 > Signed-off-by: Pasha Tatashin > Signed-off-by: David Matlack Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111002358.1842= 967-1-dmatlack@google.com?part=3D4