Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Cong Wang" <xiyou.wangcong@gmail.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Baoquan He" <baoquan.he@linux.dev>,
	"Mike Rapoport" <rppt@kernel.org>
Cc: "Alexandre Ghiti" <alex@ghiti.fr>,
	kexec@lists.infradead.org, "Cong Wang" <cwang@multikernel.io>
Subject: Re: [PATCH] riscv: kexec_file: Verify the signature of Image files
Date: Wed, 18 Nov 2026 01:50:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-219914@kernel.org> (raw)
In-Reply-To: <20261118013729.576325-1-xiyou.wangcong@gmail.com>

> From: Cong Wang <cwang@multikernel.io>
> 
> kexec_file_load() on riscv cannot check that the kernel it is given is
> trusted. KEXEC_SIG is not selectable, so a kernel that is locked down
> has to refuse kexec_file_load() altogether, and there is no way to
> restrict it to kernels signed with a trusted key.
> 
> With CONFIG_EFI the riscv Image is a PE file, the same as on arm64, and
> can carry an Authenticode signature added by tools such as sbsign.
> Verify it with kexec_kernel_verify_pe_sig(), as arm64 does, and let
> riscv select KEXEC_SIG, KEXEC_SIG_FORCE and KEXEC_IMAGE_VERIFY_SIG.
> 
> KEXEC_IMAGE_VERIFY_SIG is no longer specific to arm64, so drop "(ARM)"
> from its prompt.
> 
> [ ... ]
> 
> This is needed by multikernel, which loads its kernels with kexec_file,
> but nothing here depends on it: it applies to any kexec_file_load() user.
> 
> Signed-off-by: Cong Wang <cwang@multikernel.io>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118013729.576325-1-xiyou.wangcong@gmail.com?part=1



      reply	other threads:[~2026-11-18  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  1:37 [PATCH] riscv: kexec_file: Verify the signature of Image files Cong Wang
2026-11-18  1:50 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219914@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=baoquan.he@linux.dev \
    --cc=cwang@multikernel.io \
    --cc=kexec@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox