From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45977606A31C for ; Wed, 18 Nov 2026 06:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0ntQLLag; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VBRH3nX+ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:Reply-To: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date :Content-Transfer-Encoding:Content-Type:References:In-Reply-To:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=GEsC5dU0bfsqEDCQJOmPH05HbP/lwlu2etaBbyPSMes=; b=0ntQLLagNV1TPHADw0ms82EHLv FbOnmsAU2d+Ujc+1aXqOq0uQa3qRwLr/R+N/82+EPGdT0l6ARv96YgEfNooWQnIvUD9/wO2qxn3PP 1yFJXAAh4yvEaDXkWrdJEfEdFJT5QH0NjosEbr3eaCMoJar/7GDErbsUTTuhpZZMp6FRhXIk47idC j3vBOCzeH+eNpsgh3CTlVPyhfaMSwa9Wq15S8k/ApvrnM6wlPWZO22fabMNHZdh+cBT3X5Mn0tYdr yKzugGW9iLZyrzOxq13iCK8lOci6XOi1ksd+bHK0rWZ8XPkhzKXWaCCO1ma5hVcCNh76RfFIURu7D Lp1TxgrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYwL-00000007qZu-3oHB; Wed, 18 Nov 2026 06:14:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYwL-00000007qZl-0iS1 for kexec@lists.infradead.org; Wed, 18 Nov 2026 06:14:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6C3C740425; Wed, 18 Nov 2026 06:14:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A962E1F000C4; Wed, 18 Nov 2026 06:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794982480; bh=GEsC5dU0bfsqEDCQJOmPH05HbP/lwlu2etaBbyPSMes=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VBRH3nX+HG7tRJcwuVSjRxroM9vW1LnhK+vZ4rdcUJoOw5LWDg4vrNWwDkbiV6Suk 4woI2ffp2U/etaAL4tAgyBMdYUtalPdg4+VyHt2ZR6zQe5D8kWqojtOgmzuer/IUy2 Uey6NUQ9kGoXtdiev0Y3XJ9/L+316F9hXqKwYdeXVzBvWNZLvoZ5b4Ctk1PTMggtwj Oaz7fLeFfRWaY0wkH/Gh+ktU/i1/cTUwFVH0tL9es8+bBtoTiDQPfg2S3EaUNabKlM l8MPXkNfYYQ6qyn2HMHJ7yGlK/m5BPPbYSvSQKUrmwHwZmMd4p65dJIB5ysBt8tTSx tht8T5pnK0vJg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl To: "Zack Rusin" , "Andrew Morton" , "Petr Mladek" , "Baoquan He" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Dave Young" In-Reply-To: <4c5de34b10f579368b890eaa9333a2755886bad3.1794980455.git.zack.rusin@broadcom.com> References: <4c5de34b10f579368b890eaa9333a2755886bad3.1794980455.git.zack.rusin@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 06:14:38 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Cc: "Michael S. Tsirkin" , Kees Cook , Dave Hansen , Stephen Brennan , Bo Gan , "H. Peter Anvin" , Jonathan Corbet , Brennan Lamoreaux , x86@kernel.org, Joel Granados , Alexey Makhalov , Eugenio Perez , Ingo Molnar , bcm-kernel-feedback-list@broadcom.com, Ajay Kaher , Bradley Morgan , John Ogness , virtualization@lists.linux.dev, Steven Rostedt , Maaz Mombasawala , Borislav Petkov , Shuah Khan , Michael Kelley , Randy Dunlap , kexec@lists.infradead.org, Ian Forbes , Sergey Senozhatsky , Thomas Gleixner Sender: "kexec" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Allow administrators to disable host log transfer on ordinary guests or > opt in on encrypted guests. Expose the boolean recording policy through > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested. > Zero disables recording, nonzero integers enable it, and reads return > 0 or 1. >=20 > Register the sysctl only after the logger is ready. A registration failure > leaves the internal default in force. Document that the log is sent > before kdump, and that disable_panic_notifiers_platform_list also skips > it. >=20 > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw= 7f3zjbz7c@srfabx6lsusj > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1794980455.gi= t.zack.rusin@broadcom.com?part=3D3