Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Federico Parola" <fparola@amazon.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Baoquan He" <baoquan.he@linux.dev>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Pasha Tatashin" <pasha.tatashin@soleen.com>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Zhen Lei" <thunder.leizhen@huawei.com>,
	kexec@lists.infradead.org
Cc: nh-open-source@amazon.com
Subject: Re: [PATCH] crash: Fix crash memory reserve dead loop when low and high limits match
Date: Thu, 19 Nov 2026 09:47:01 +0000	[thread overview]
Message-ID: <sashiko-outbox-222864@kernel.org> (raw)
In-Reply-To: <20261119093730.49471-1-fparola@amazon.de>

> On arm64 with neither CONFIG_ZONE_DMA nor CONFIG_ZONE_DMA32,
> arm64_dma_phys_limit is PHYS_MASK + 1, so CRASH_ADDR_LOW_MAX equals
> CRASH_ADDR_HIGH_MAX. If the first crashkernel=size[KMG] attempt fails,
> reserve_crashkernel_generic() falls back to [CRASH_ADDR_LOW_MAX,
> CRASH_ADDR_HIGH_MAX), which is empty. That attempt fails too, and since
> search_end still equals CRASH_ADDR_LOW_MAX the fallback is taken again,
> forever. Boot stalls after the "Initmem setup" messages.
> 
> The first attempt can fail on a kexec handover (KHO) boot, where early
> allocations are confined to the KHO scratch areas.
> 
> Commit edb907a61333 ("crash: fix riscv64 crash memory reserve dead
> loop") fixed the same loop for crashkernel=size[KMG],high. Skip the
> fallback to high memory when there is none, so the reservation fails
> with "cannot allocate crashkernel" and boot continues.
> 
> Fixes: 0ab97169aa05 ("crash_core: add generic function to do reservation")
> CC: stable@vger.kernel.org
> Signed-off-by: Federico Parola <fparola@amazon.de>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119093730.49471-1-fparola@amazon.de?part=1



      reply	other threads:[~2026-11-19  9:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:37 [PATCH] crash: Fix crash memory reserve dead loop when low and high limits match Federico Parola
2026-11-19  9:47 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222864@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=baoquan.he@linux.dev \
    --cc=fparola@amazon.de \
    --cc=kexec@lists.infradead.org \
    --cc=nh-open-source@amazon.com \
    --cc=palmer@dabbelt.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=pjw@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox