From: sashiko-bot@kernel.org
To: "Xiaotao Zeng" <zengxiaotao@kylinos.cn>,
pasha.tatashin@soleen.com, rppt@kernel.org, pratyush@kernel.org
Cc: kexec@lists.infradead.org, duanchenghao@kylinos.cn
Subject: Re: [PATCH] liveupdate: drop redundant lower-bound check in luo_session_ioctl
Date: Fri, 20 Nov 2026 07:56:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-224665@kernel.org> (raw)
In-Reply-To: <20261120075252.684604-1-zengxiaotao@kylinos.cn>
> nr is unsigned, so for cmd values below LIVEUPDATE_CMD_SESSION_BASE the
> subtraction nr - LIVEUPDATE_CMD_SESSION_BASE wraps to a large value that
> is already rejected by the ARRAY_SIZE() upper-bound check. The lower
> bound test is therefore redundant.
>
> Drop it so the check matches the one in luo_ioctl().
>
> Signed-off-by: Xiaotao Zeng <zengxiaotao@kylinos.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120075252.684604-1-zengxiaotao@kylinos.cn?part=1
prev parent reply other threads:[~2026-11-20 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 7:52 [PATCH] liveupdate: drop redundant lower-bound check in luo_session_ioctl Xiaotao Zeng
2026-11-20 7:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224665@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=duanchenghao@kylinos.cn \
--cc=kexec@lists.infradead.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zengxiaotao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox