From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Tue, 28 May 2019 14:09:20 +0000 Subject: Re: [PATCH v10 12/12] ima: Store the measurement again when appraising a modsig Message-Id: <1559052560.4090.14.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20190418035120.2354-1-bauerman@linux.ibm.com> <20190418035120.2354-13-bauerman@linux.ibm.com> In-Reply-To: <20190418035120.2354-13-bauerman@linux.ibm.com> To: Thiago Jung Bauermann , linux-integrity@vger.kernel.org Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Howells , David Woodhouse , Jessica Yu , Herbert Xu , "David S. Miller" , Jonathan Corbet , "AKASHI, Takahiro" SGkgVGhpYWdvLAoKT24gVGh1LCAyMDE5LTA0LTE4IGF0IDAwOjUxIC0wMzAwLCBUaGlhZ28gSnVu ZyBCYXVlcm1hbm4gd3JvdGU6Cj4gSWYgdGhlIElNQSB0ZW1wbGF0ZSBjb250YWlucyB0aGUgIm1v ZHNpZyIgb3IgImQtbW9kc2lnIiBmaWVsZCwgdGhlbiB0aGUKPiBtb2RzaWcgc2hvdWxkIGJlIGFk ZGVkIHRvIHRoZSBtZWFzdXJlbWVudCBsaXN0IHdoZW4gdGhlIGZpbGUgaXMgYXBwcmFpc2VkLgo+ IAo+IEFuZCB0aGF0IGlzIHdoYXQgbm9ybWFsbHkgaGFwcGVucywgYnV0IGlmIGEgbWVhc3VyZW1l bnQgcnVsZSBjYXVzZWQgYSBmaWxlCj4gY29udGFpbmluZyBhIG1vZHNpZyB0byBiZSBtZWFzdXJl ZCBiZWZvcmUgYSBkaWZmZXJlbnQgcnVsZSBjYXVzZXMgaXQgdG8gYmUKPiBhcHByYWlzZWQsIHRo ZSByZXN1bHRpbmcgbWVhc3VyZW1lbnQgZW50cnkgd2lsbCBub3QgY29udGFpbiB0aGUgbW9kc2ln Cj4gYmVjYXVzZSBpdCBpcyBvbmx5IGZldGNoZWQgZHVyaW5nIGFwcHJhaXNhbC4gV2hlbiB0aGUg YXBwcmFpc2FsIHJ1bGUKPiB0cmlnZ2VycywgaXQgd29uJ3Qgc3RvcmUgYSBuZXcgbWVhc3VyZW1l bnQgY29udGFpbmluZyB0aGUgbW9kc2lnIGJlY2F1c2UKPiB0aGUgZmlsZSB3YXMgYWxyZWFkeSBt ZWFzdXJlZC4KPiAKPiBXZSBuZWVkIHRvIGRldGVjdCB0aGF0IHNpdHVhdGlvbiBhbmQgc3RvcmUg YW4gYWRkaXRpb25hbCBtZWFzdXJlbWVudCB3aXRoCj4gdGhlIG1vZHNpZy4gVGhpcyBpcyBkb25l IGJ5IGFkZGluZyBhbiBJTUFfTUVBU1VSRSBhY3Rpb24gZmxhZyBpZiB3ZSByZWFkIGEKPiBtb2Rz aWcgYW5kIHRoZSBJTUEgdGVtcGxhdGUgY29udGFpbnMgYSBtb2RzaWcgZmllbGQuCgpXaXRoIHRo ZSBuZXcgcGVyIHBvbGljeSBydWxlICJ0ZW1wbGF0ZSIgc3VwcG9ydCBiZWluZyBhZGRlZCwgdGhp cwpwYXRjaCBuZWVkcyB0byBiZSBtb2RpZmllZCBzbyB0aGF0IHRoZSBwZXIgcG9saWN5ICJ0ZW1w bGF0ZSIgZm9ybWF0IGlzCmNoZWNrZWQuIMKgaW1hX3RlbXBsYXRlX2hhc19tb2RzaWcoKSBzaG91 bGQgYmUgY2FsbGVkIHdpdGggdGhlCnRlbXBsYXRlX2Rlc2MgYmVpbmcgdXNlZC4KCnRoYW5rcywK Ck1pbWkKCgo+IGRpZmYgLS1naXQgYS9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9tYWluLmMg Yi9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9tYWluLmMKPiBpbmRleCA4ZTY0NzU4NTQzNTEu LmY5MWVkNDE4OWY5OCAxMDA2NDQKPiAtLS0gYS9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9t YWluLmMKPiArKysgYi9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9tYWluLmMKPiBAQCAtMjgy LDkgKzI4MiwxNyBAQCBzdGF0aWMgaW50IHByb2Nlc3NfbWVhc3VyZW1lbnQoc3RydWN0IGZpbGUg KmZpbGUsIGNvbnN0IHN0cnVjdCBjcmVkICpjcmVkLAo+ICAJCS8qIHJlYWQgJ3NlY3VyaXR5Lmlt YScgKi8KPiAgCQl4YXR0cl9sZW4gPSBpbWFfcmVhZF94YXR0cihmaWxlX2RlbnRyeShmaWxlKSwg JnhhdHRyX3ZhbHVlKTsKPiAgCj4gLQkJLyogUmVhZCB0aGUgYXBwZW5kZWQgbW9kc2lnIGlmIGFs bG93ZWQgYnkgdGhlIHBvbGljeS4gKi8KPiAtCQlpZiAoaWludC0+ZmxhZ3MgJiBJTUFfTU9EU0lH X0FMTE9XRUQpCj4gLQkJCWltYV9yZWFkX21vZHNpZyhmdW5jLCBidWYsIHNpemUsICZtb2RzaWcp Owo+ICsJCS8qCj4gKwkJICogUmVhZCB0aGUgYXBwZW5kZWQgbW9kc2lnLCBpZiBhbGxvd2VkIGJ5 IHRoZSBwb2xpY3ksIGFuZCBhbGxvdwo+ICsJCSAqIGFuIGFkZGl0aW9uYWwgbWVhc3VyZW1lbnQg bGlzdCBlbnRyeSwgaWYgbmVlZGVkLCBiYXNlZCBvbiB0aGUKPiArCQkgKiB0ZW1wbGF0ZSBmb3Jt YXQuCj4gKwkJICovCj4gKwkJaWYgKGlpbnQtPmZsYWdzICYgSU1BX01PRFNJR19BTExPV0VEKSB7 Cj4gKwkJCXJjID0gaW1hX3JlYWRfbW9kc2lnKGZ1bmMsIGJ1Ziwgc2l6ZSwgJm1vZHNpZyk7Cj4g Kwo+ICsJCQlpZiAoIXJjICYmIGltYV90ZW1wbGF0ZV9oYXNfbW9kc2lnKCkpCj4gKwkJCQlhY3Rp b24gfD0gSU1BX01FQVNVUkU7Cj4gKwkJfQo+IAo=