From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Mon, 16 Mar 2020 11:50:51 +0000 Subject: Re: [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore Message-Id: <1797278.1584359451@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200313152102.1707-2-longman@redhat.com> <20200313152102.1707-1-longman@redhat.com> In-Reply-To: <20200313152102.1707-2-longman@redhat.com> To: Waiman Long Cc: dhowells@redhat.com, Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen Waiman Long wrote: > include/linux/key-type.h | 2 +- > security/keys/big_key.c | 11 ++--- > security/keys/encrypted-keys/encrypted.c | 7 ++- > security/keys/keyctl.c | 57 +++++++++++++++++++---- > security/keys/keyring.c | 6 +-- > security/keys/request_key_auth.c | 7 ++- > security/keys/trusted-keys/trusted_tpm1.c | 14 +----- > security/keys/user_defined.c | 5 +- > ... > - long (*read)(const struct key *key, char __user *buffer, size_t buflen); > + long (*read)(const struct key *key, char *buffer, size_t buflen); Note that there are read functions outside of security/keys/ that also need fixing - dns_resolver_read() and rxrpc_read(). David