From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Date: Wed, 09 Jan 2019 17:34:55 +0000 Subject: Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler Message-Id: <20190109173454.GB249140@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1250" Content-Transfer-Encoding: base64 List-Id: References: <20190103143227.9138-1-jlee@suse.com> <1894062.aDvIuj92vB@tauon.chronox.de> <20190109082103.GA8586@sol.localdomain> <2344329.gmPllosFfp@tauon.chronox.de> In-Reply-To: <2344329.gmPllosFfp@tauon.chronox.de> To: Stephan Mueller Cc: James Bottomley , Andy Lutomirski , Herbert Xu , "Lee, Chun-Yi" , "Rafael J . Wysocki" , Pavel Machek , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, keyrings@vger.kernel.org, "Rafael J. Wysocki" , Chen Yu , Oliver Neukum , Ryan Chen , David Howells , Giovanni Gherdovich , Randy Dunlap , Jann Horn , Andy Lutomirski T24gV2VkLCBKYW4gMDksIDIwMTkgYXQgMTE6MTc6NDVBTSArMDEwMCwgU3RlcGhhbiBNdWVsbGVy IHdyb3RlOgo+IEFtIE1pdHR3b2NoLCA5LiBKYW51YXIgMjAxOSwgMDk6MjE6MDQgQ0VUIHNjaHJp ZWIgRXJpYyBCaWdnZXJzOgo+IAo+IEhpIEVyaWMsCj4gPiAKPiA+IEZXSVcsIGl0J3MgYmVlbiB2 ZXJ5IHNsb3cgZ29pbmcgc2luY2UgSSd2ZSBiZWVuIHdvcmtpbmcgb24gb3RoZXIgcHJvamVjdHMK PiA+IGFuZCBJIGFsc28gbmVlZCB0byBiZSB2ZXJ5IHN1cmUgdG8gZ2V0IHRoZSBBUEkgY2hhbmdl cyByaWdodCwgYnV0IEkgc3RpbGwKPiA+IHBsYW4gdG8gY2hhbmdlIHRoZSBLREYgaW4gZnNjcnlw dCAoYS5rLmEuIGV4dDQvZjJmcy91YmlmcyBlbmNyeXB0aW9uKSB0bwo+ID4gSEtERi1TSEE1MTIg YXMgcGFydCBvZiBhIGxhcmdlciBzZXQgb2YgaW1wcm92ZW1lbnRzIHRvIGhvdyBmc2NyeXB0Cj4g PiBlbmNyeXB0aW9uIGtleXMgYXJlIG1hbmFnZWQuIEkgc2VudCB0aGUgbGFzdCBwYXRjaHNldCBh IHllYXIgYWdvCj4gPiAoaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtZnNkZXZlbCZtFTA4Nzk0 OTMyMDYyNTcpIGJ1dCBJJ20gd29ya2luZyB0bwo+ID4gcmV2aXZlIGl0LiAgSW4gdGhlIHdvcmst aW4tcHJvZ3Jlc3MgdmVyc2lvbiBpbiBteSBnaXQgdHJlZSwgdGhpcyBpcyB0aGUKPiA+IGNvbW1p dCB0aGF0IGFkZHMgYSBIS0RGIGltcGxlbWVudGF0aW9uIGFzIGZzL2NyeXB0by9oa2RmLmM6Cj4g PiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9lYmlnZ2Vy cy9saW51eC5naXQvY29tbWl0Lz9pZOhhNzg3NjcxMzFjOTcxN2VlODM4ZjBjNGUzMDc5NDhkNjVh NDQyNwo+ID4gSXQgYmFzaWNhbGx5IGp1c3Qgd3JhcHMgYSBjcnlwdG9fc2hhc2ggZm9yICJobWFj KHNoYTUxMikiLgo+ID4gCj4gPiBJJ2QgYmUgZmluZSB3aXRoIHVzaW5nIGEgY29tbW9uIGltcGxl bWVudGF0aW9uIGluc3RlYWQsIHByb3ZpZGVkIHRoYXQgaXQKPiA+IGdpdmVzIHRoZSBzYW1lIGZ1 bmN0aW9uYWxpdHksIGluY2x1ZGluZyBzdXBwb3J0aW5nIHVzZXItc3BlY2lmaWVkIHNhbHQgYW5k Cj4gPiBhcHBsaWNhdGlvbi1zcGVjaWZpYyBpbmZvIHN0cmluZ3MsIGFuZCBpc24ndCBzbG93ZXIg b3IgbW9yZSBjb21wbGV4IHRvIHVzZS4KPiA+IAo+ID4gKFRoaXMgY29tbWVudCBpcyBzb2xlbHkg b24gdGhlIHRhbmdlbnRpYWwgZGlzY3Vzc2lvbiBhYm91dCBLREYKPiA+IGltcGxlbWVudGF0aW9u czsgSSd2ZSBub3QgbG9va2VkIGF0IHRoZSBoaWJlcm5hdGlvbiBpbWFnZSBlbmNyeXB0aW9uIHN0 dWZmCj4gPiB5ZXQuKQo+IAo+IFRoYW5rcyBmb3IgdGhlIGNsYXJpZmljYXRpb24uIEkgaGF2ZSBz dGFydGVkIGEgZ2VuZXJpYyBIS0RGIGltcGxlbWVudGF0aW9uIGZvciAKPiB0aGUga2VybmVsIGNy eXB0byBBUEkgd2hpY2ggbGVhZCB0byB0aGUgcXVlc3Rpb25zIGFib3ZlLiBJIHdvdWxkIHRoZW4g YWxzbyB0cnkgCj4gdG8gcHJvdmlkZSBhIEhLREYgcHJvcG9zYWwuCj4gCj4gVG8gdXNlIHRoZSAo SClLREYsIEkgY3VycmVudGx5IGVudmlzaW9uIDIgY2FsbHMgYXBhcnQgZnJvbSBhbGxvYy9mcmVl LiBUaGUgCj4gZm9sbG93aW5nIGNvZGUgd291bGQgc2VydmUgYXMgYW4gZXhhbXBsZS4KPiAKPiAg KiBFeGFtcGxlIHdpdGhvdXQgcHJvcGVyIGVycm9yIGhhbmRsaW5nOgo+ICAqICAgICAgY2hhciAq a2V5aW5nX21hdGVyaWFsID0gIlx4MDBceDExXHgyMlx4MzNceDQ0XHg1NVx4NjZceDc3IjsKPiAg KiAgICAgIGNoYXIgKmxhYmVsX2NvbnRleHQgPSAiXHhkZVx4YWRceGJlXHhlZlx4MDBceGRlXHhh ZFx4YmVceGVmIjsKPiAgKiAgICAgIGtkZiA9IGNyeXB0b19hbGxvY19ybmcobmFtZSwgMCwgMCk7 Cj4gICogICAgICBjcnlwdG9fcm5nX3Jlc2V0KGtkZiwga2V5aW5nX21hdGVyaWFsLCA4KTsKPiAg KiAgICAgIGNyeXB0b19ybmdfZ2VuZXJhdGUoa2RmLCBsYWJlbF9jb250ZXh0LCA5LCBvdXRidWYs IG91dGJ1Zmxlbik7Cj4gCj4gVGhhdCBob3BlZnVsbHkgc2hvdWxkIGJlIHNpbXBsZSBlbm91Z2gu Cj4gCj4gRm9yIEhLREYsIGFzIG1lbnRpb25lZCwgSSB3b3VsZCBlbnZpc2lvbiB0byB1c2UgYSBz dHJ1Y3QgaW5zdGVhZCBvZiBhIGNoYXIgKiAKPiBmb3IgdGhlIGxhYmVsX2NvbnRleHQgdG8gY29t bXVuaWNhdGUgSUtNLCBTYWx0LCBhbmQgdGhlIGxhYmVsL2luZm8gCj4gaW5mb3JtYXRpb24uCj4g Cj4gQ2lhbwo+IFN0ZXBoYW4KPiAKClRoYXQgd291bGQgbm90IG1lZXQgbXkgcGVyZm9ybWFuY2Ug cmVxdWlyZW1lbnRzIGFzIEkgd2FudCB0byBwcmVjb21wdXRlCkhLREYtRXh0cmFjdCwgYW5kIHRo ZW4gZG8gSEtERi1FeHBhbmQgbWFueSB0aW1lcy4gIEFsc28gdGhlIEhLREYtRXhwYW5kIHBhcnQK c2hvdWxkIGJlIHRocmVhZC1zYWZlIGFuZCBub3QgcmVxdWlyZSBhbGxvY2F0aW5nIG1lbW9yeSwg ZXNwZWNpYWxseSBub3QgYSB3aG9sZQpjcnlwdG9fc2hhc2ggdGZtIGV2ZXJ5IHRpbWUuCgpTbyBw cmVzdW1hYmx5IHdpdGggY3J5cHRvX3JuZywgY3J5cHRvX3JuZ19yZXNldCgpIHdvdWxkIG5lZWQg dG8gdGFrZSB0aGUgaW5wdXQKa2V5cmluZyBtYXRlcmlhbCBhbmQgc2FsdCBhbmQgZG8gSEtERi1F eHRyYWN0IChsaWtlIG15IGZzY3J5cHRfaW5pdF9oa2RmKCkpLCBhbmQKY3J5cHRvX3JuZ19nZW5l cmF0ZSgpIHdvdWxkIG5lZWQgdG8gdGFrZSB0aGUgYXBwbGljYXRpb24tc3BlY2lmaWMgaW5mbyBz dHJpbmcKYW5kIGRvIEhLREYtRXhwYW5kIChsaWtlIG15IGZzY3J5cHRfaGtkZl9leHBhbmQoKSku CgpJdCBpcyB1Z2x5IHRob3VnaC4gIFBsZWFzZSBhbHNvIGNvbnNpZGVyIGp1c3QgaGF2aW5nIHNp bXBsZSBjcnlwdG9faGtkZl8qKCkKaGVscGVyIGZ1bmN0aW9ucyB3aGljaCB3cmFwIGEgSE1BQyB0 Zm0gYWxvbmcgdGhlIGxpbmVzIG9mIG15IHBhdGNoLCByYXRoZXIgdGhhbgpzaG9laG9ybmluZyBp dCBpbnRvIHRoZSBjcnlwdG9fcm5nIEFQSS4KCi0gRXJpYw==