From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Fri, 14 Jun 2019 11:12:59 +0000 Subject: Re: [PATCH, RFC 20/62] mm/page_ext: Export lookup_page_ext() symbol Message-Id: <20190614111259.GA3436@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20190508144422.13171-1-kirill.shutemov@linux.intel.com> <20190508144422.13171-21-kirill.shutemov@linux.intel.com> In-Reply-To: <20190508144422.13171-21-kirill.shutemov@linux.intel.com> To: "Kirill A. Shutemov" Cc: Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Andy Lutomirski , David Howells , Kees Cook , Dave Hansen , Kai Huang , Jacob Pan , Alison Schofield , linux-mm@kvack.org, kvm@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, May 08, 2019 at 05:43:40PM +0300, Kirill A. Shutemov wrote: > page_keyid() is inline funcation that uses lookup_page_ext(). KVM is > going to use page_keyid() and since KVM can be built as a module > lookup_page_ext() has to be exported. I _really_ hate having to export world+dog for KVM. This one might not be a real issue, but I itch every time I see an export for KVM these days.