From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Date: Mon, 12 Aug 2019 22:20:03 +0000 Subject: Re: [PATCH v8 05/20] fscrypt: rename fscrypt_master_key to fscrypt_direct_key Message-Id: <20190812222003.GD28705@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20190805162521.90882-1-ebiggers@kernel.org> <20190805162521.90882-6-ebiggers@kernel.org> In-Reply-To: <20190805162521.90882-6-ebiggers@kernel.org> To: Eric Biggers Cc: Satya Tangirala , linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley On Mon, Aug 05, 2019 at 09:25:06AM -0700, Eric Biggers wrote: > From: Eric Biggers > > In preparation for introducing a filesystem-level keyring which will > contain fscrypt master keys, rename the existing 'struct > fscrypt_master_key' to 'struct fscrypt_direct_key'. This is the > structure in the existing table of master keys that's maintained to > deduplicate the crypto transforms for v1 DIRECT_KEY policies. > > I've chosen to keep this table as-is rather than make it automagically > add/remove the keys to/from the filesystem-level keyring, since that > would add a lot of extra complexity to the filesystem-level keyring. > > Signed-off-by: Eric Biggers Looks good. You can add: Reviewed-by: Theodore Ts'o - Ted