Re: [PATCH v7 2/5] KEYS: trusted: Change -EINVAL to -E2BIG

Stefan Berger
2024-05-29T01:50:49Z

On 5/28/24 17:08, Jarkko Sakkinen wrote:
> Report -E2BIG instead of -EINVAL when too large size for the key blob is
> requested.
>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
> security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c
> index 8b7dd73d94c1..06c8fa7b21ae 100644
> --- a/security/keys/trusted-keys/trusted_tpm2.c
> +++ b/security/keys/trusted-keys/trusted_tpm2.c
> @@ -122,7 +122,7 @@ static int tpm2_key_decode(struct trusted_key_payload *payload,
> return ret;
>
> if (ctx.priv_len + ctx.pub_len > MAX_BLOB_SIZE)
> - return -EINVAL;
> + return -E2BIG;
>
> blob = kmalloc(ctx.priv_len + ctx.pub_len + 4, GFP_KERNEL);
> if (!blob)