From: Eric Biggers <ebiggers@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v2 0/3] KEYS: trusted_tpm1: HMAC fix and cleanup
Date: Sat, 9 Aug 2025 10:19:38 -0700 [thread overview]
Message-ID: <20250809171941.5497-1-ebiggers@kernel.org> (raw)
Patch 1 fixes the HMAC-SHA1 comparison in trusted_tpm1 to be
constant-time.
Patch 2 simplifies the SHA-1 and HMAC-SHA1 computation in trusted_tpm1
by using library APIs instead of crypto_shash. Note that this depends
on the SHA-1 and HMAC-SHA1 library APIs that were merged for v6.17-rc1.
Patch 3 is a trusted_tpm1 cleanup that moves private functionality out
of a public header.
Changed in v2:
- Added the requested note to the commit message of patch 1.
- Added a Reviewed-by tag
Eric Biggers (3):
KEYS: trusted_tpm1: Compare HMAC values in constant time
KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shash
KEYS: trusted_tpm1: Move private functionality out of public header
include/keys/trusted_tpm.h | 79 ------
security/keys/trusted-keys/Kconfig | 5 +-
security/keys/trusted-keys/trusted_tpm1.c | 284 ++++++++--------------
3 files changed, 100 insertions(+), 268 deletions(-)
base-commit: 561c80369df0733ba0574882a1635287b20f9de2
--
2.50.1
next reply other threads:[~2025-08-09 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 17:19 Eric Biggers [this message]
2025-08-09 17:19 ` [PATCH v2 1/3] KEYS: trusted_tpm1: Compare HMAC values in constant time Eric Biggers
2025-08-12 16:23 ` Jarkko Sakkinen
2025-08-09 17:19 ` [PATCH v2 2/3] KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shash Eric Biggers
2025-08-12 16:24 ` Jarkko Sakkinen
2025-08-09 17:19 ` [PATCH v2 3/3] KEYS: trusted_tpm1: Move private functionality out of public header Eric Biggers
2025-08-12 16:24 ` Jarkko Sakkinen
2025-08-12 16:29 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250809171941.5497-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox