From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6103E33F5B4 for ; Sun, 23 Aug 2026 15:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787498951; cv=none; b=tT5cKCmlacGZbxUlRf1BkZYqgn0swTYqTzuZYH3hvl504lHOWBaaCMKXmPQFfpc9HMJSft+BiwecbRMXfNgYLtsGNR04IP01ORNirzTme1fhPiWhrDuy42cZExs/K7t1yfwzcf0r9xn/3nrdWABUA2+Z1mnTAqLNSkWQauxw5qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787498951; c=relaxed/simple; bh=noH06bWbd9au3QwTfyCzv6YG/11P0qQ2GQOGnBRkOM8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AhTBWVgZRkTkRt4e3EQVLdTugQz2FS4OkSgs9yWY4Q8Ksq1ytK2EbmpOuechGyY7GPMQ5rm7l7y7yKKcQt6HedOv1GuFco9JJm7nRIL1GbKSWheQ0K9kr57qt7EgYXsNXSzjAB9pciB1wWGdMU7cdfYbZvkcl0gbRmRwMEmfDwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FOpu+1pt; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FOpu+1pt" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-81fffc7e5dfso2323167b3.3 for ; Sun, 23 Aug 2026 08:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787498947; x=1788103747; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OFwQKaYUKYWnpFig82RL6B4iFCO0UHPAGhK0xZ0RmTw=; b=FOpu+1ptZtZAkMi0rwj1xwe3oHGFeiP3SZtzIB0mjYlNpDi/c13lHNaiZ36jkPYGmU RYMxwtCcssI7OWU1qYGT7qmdhxUkVT6DVKGWMWEOiVUwLYbwx/Onjpj05AC7yoMHVFqW 2k7V2CadXy+YNBiP/urVQGjYZU+VZwDE13fKHZAswfCraYBLP1h8mwCkdL00c/Eyc2Zr 2sg87EmLQ0NdqrBH4gHG04zCPmk88BzDJ0PI3pFYoR/UZQHV5ymCQasoxqaLDtG0Q4/H mt4NMfpufjyZX2nOq6kfM3jIwRsLpdDP2DvGa55oZASldr/D61bWA6lzhKVQD33F79Z3 Nw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787498947; x=1788103747; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OFwQKaYUKYWnpFig82RL6B4iFCO0UHPAGhK0xZ0RmTw=; b=a/IGjZJJDAd+C0D8S0or899bPBylZyNa617UDrNukmYfaM56PxJ1qnKwL+fjK0wUAF ghGivV1W5Km2Fxk7OjK2Cw0Ue0GoD3AjXdnPPc0+iOKF8Vt+btQSlbDPGoCaKbzE+utL 4rXKjTMoB8jAVJFACjhLBSaE1uQJ2nsLgCeYB0OyErJYs8rAYYfeUEs1ORSvRDSceBiW 0JjeIQD6oqIlQ3G+cik6B7v6Cjf9k91iBlLGWp+V6J10xjoPLs0Y6BGL5V11VOmaX8lq HXce+iOQSAC04PqcmEew/j5X00U0XFeiPOmgIw+dQNcWQ5e1v8ucz1JZTLGKTuwL499A k0fg== X-Gm-Message-State: AFuF++mNXYvgmZm8wZKnbfL17WT+FeDkpeiNRzHnCJfFt+IrSLeQlILP 2LyikH20v+RvEzLeJsVuousKnf80rFQ4ee5OrvH+CjGWE5jiSuLY48f70ibXQvZCC7wLxQ== X-Gm-Gg: AR+sD12kvBRclAWvOdVy2IvzMR5+FmplbGRtwNOsd/MQ+m6QuKxEACSKbPLp7C0U7iw VfZ/+iHZsh4Zoe6bvzroC849jjFysnIl1/WZg6XmZsRt9eIX7aPtqhG94Rjdz9uisHf59cwYHRb LWwFf//WtC5WE86FZ+1uwmNiIJ61CZ+zc56s8yc8nxo337AL0ED6w2Nsns0cA/ITa320AYmIvob +h145fPIWcKR0cf1j9S4SRIEf4HKbxKI0Y5Xkr3IqtugqS0s65meV0SLGmIUz/LKXfXrbbyA9vW GCUjUkVLJ631JN15qb9ixyDGWzCjYmBt3utslSSDB8fT4M4jMrJcD3Uyp7rNWb91DoiEAyRoP6E 4qEPuiUuheC3q6lzt3ygtFDUapiZFwb0NzSciJvwn4p8DqeLAjIW5SpkIvyLFoW/+AAKBd+KNn3 zaxIwrP4rWSRJHk9Btnur2pNiPiG0FPlQt/p/t1CwY/IsGATRx74gsNNgl8X0Kt+bD9qN32Op7L oU27ng/rOp35yo5mqgHe5KENL/Yi0NYEih964dp/p+bGceyhJnTNC+mNjQ73mI7kg== X-Received: by 2002:a05:690c:b96:b0:81f:45f0:21b7 with SMTP id 00721157ae682-849ea4f7f47mr87069237b3.0.1787498947218; Sun, 23 Aug 2026 08:29:07 -0700 (PDT) Received: from localhost.localdomain (45.78.65.84.16clouds.com. [45.78.65.84]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84cab84ef2esm21895757b3.34.2026.08.23.08.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 08:29:06 -0700 (PDT) From: Chengfeng Ye To: David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , Serge Hallyn Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chengfeng Ye Subject: [PATCH] keys: Fix key_user use-after-free during ownership changes Date: Sun, 23 Aug 2026 23:28:58 +0800 Message-ID: <20260823152858.3839939-1-nicoyip.dev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: keyrings@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit keyctl_chown_key() replaces key->user while holding key->sem and drops the old key_user reference after releasing the semaphore. The /proc/keys iterators and find_keyring_by_name() instead dereference key->user while holding unrelated locks. This allows the following interleaving: CPU 0 (/proc/keys) CPU 1 (KEYCTL_CHOWN) load old key->user replace key->user key_user_put(old) kfree(old) read old->uid Serialize the namespace-mapping reads and the pointer replacement with key_user_lock. This lock already protects final key_user removal, so the old object cannot be freed while its uid is being read. Keep reading the quota-owner UID rather than key->uid because those values can legitimately differ for thread keyrings. Signed-off-by: Chengfeng Ye --- security/keys/internal.h | 10 ++++++++++ security/keys/keyctl.c | 2 ++ security/keys/keyring.c | 2 +- security/keys/proc.c | 4 ++-- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/security/keys/internal.h b/security/keys/internal.h index b7b622bc36a1..741d547ba5c4 100644 --- a/security/keys/internal.h +++ b/security/keys/internal.h @@ -70,6 +70,16 @@ extern struct key_user root_key_user; extern struct key_user *key_user_lookup(kuid_t uid); extern void key_user_put(struct key_user *user); +static inline kuid_t key_user_uid(const struct key *key) +{ + kuid_t uid; + + spin_lock(&key_user_lock); + uid = key->user->uid; + spin_unlock(&key_user_lock); + return uid; +} + /* * Key quota limits. * - root has its own separate limits to everyone else diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index d14ace88e529..c17924609317 100644 --- a/security/keys/keyctl.c +++ b/security/keys/keyctl.c @@ -1036,8 +1036,10 @@ long keyctl_chown_key(key_serial_t id, uid_t user, gid_t group) atomic_inc(&newowner->nikeys); } + spin_lock(&key_user_lock); zapowner = key->user; key->user = newowner; + spin_unlock(&key_user_lock); key->uid = uid; } diff --git a/security/keys/keyring.c b/security/keys/keyring.c index 15bf4af8f282..49f4be934525 100644 --- a/security/keys/keyring.c +++ b/security/keys/keyring.c @@ -1158,7 +1158,7 @@ struct key *find_keyring_by_name(const char *name, bool uid_keyring) * grants Search permission and that hasn't been revoked */ list_for_each_entry(keyring, &ns->keyring_name_list, name_link) { - if (!kuid_has_mapping(ns, keyring->user->uid)) + if (!kuid_has_mapping(ns, key_user_uid(keyring))) continue; if (test_bit(KEY_FLAG_REVOKED, &keyring->flags)) diff --git a/security/keys/proc.c b/security/keys/proc.c index 4f4e2c1824f1..8d6d26652aab 100644 --- a/security/keys/proc.c +++ b/security/keys/proc.c @@ -68,7 +68,7 @@ static struct rb_node *key_serial_next(struct seq_file *p, struct rb_node *n) n = rb_next(n); while (n) { struct key *key = rb_entry(n, struct key, serial_node); - if (kuid_has_mapping(user_ns, key->user->uid)) + if (kuid_has_mapping(user_ns, key_user_uid(key))) break; n = rb_next(n); } @@ -100,7 +100,7 @@ static struct key *find_ge_key(struct seq_file *p, key_serial_t id) return NULL; for (;;) { - if (kuid_has_mapping(user_ns, minkey->user->uid)) + if (kuid_has_mapping(user_ns, key_user_uid(minkey))) return minkey; n = rb_next(&minkey->serial_node); if (!n) -- 2.43.0