From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Date: Tue, 18 Jun 2019 14:13:56 +0000 Subject: Re: [PATCH, RFC 45/62] mm: Add the encrypt_mprotect() system call for MKTME Message-Id: <32d5332d-b549-9ffd-b1d1-72dcd83bbb5f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20190508144422.13171-1-kirill.shutemov@linux.intel.com> <20190508144422.13171-46-kirill.shutemov@linux.intel.com> <3c658cce-7b7e-7d45-59a0-e17dae986713@intel.com> <5cbfa2da-ba2e-ed91-d0e8-add67753fc12@intel.com> <1560816342.5187.63.camel@linux.intel.com> In-Reply-To: To: Andy Lutomirski , Kai Huang Cc: "Kirill A. Shutemov" , Andrew Morton , X86 ML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Peter Zijlstra , David Howells , Kees Cook , Jacob Pan , Alison Schofield , Linux-MM , kvm list , keyrings@vger.kernel.org, LKML , Tom Lendacky On 6/17/19 5:15 PM, Andy Lutomirski wrote: >>> But I really expect that the encryption of a DAX device will actually >>> be a block device setting and won't look like this at all. It'll be >>> more like dm-crypt except without device mapper. >> Are you suggesting not to support MKTME for DAX, or adding MKTME support to dm-crypt? > I'm proposing exposing it by an interface that looks somewhat like > dm-crypt. Either we could have a way to create a device layered on > top of the DAX devices that exposes a decrypted view or we add a way > to tell the DAX device to kindly use MKTME with such-and-such key. I think this basically implies that we need to settle (or at least present) on an interface for storage (FS-DAX, Device DAX, page cache) before we merge one for anonymous memory. That sounds like a reasonable exercise.