From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Fri, 20 Mar 2020 23:55:10 +0000 Subject: Re: [PATCH v5 2/2] KEYS: Avoid false positive ENOMEM error on key read Message-Id: <3984029.1584748510@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200320143547.GB3629@linux.intel.com> <20200318221457.1330-1-longman@redhat.com> <20200318221457.1330-3-longman@redhat.com> <20200319194650.GA24804@linux.intel.com> <20200320020717.GC183331@linux.intel.com> <7dbc524f-6c16-026a-a372-2e80b40eab30@redhat.com> In-Reply-To: <20200320143547.GB3629@linux.intel.com> To: Jarkko Sakkinen Cc: dhowells@redhat.com, Waiman Long , James Morris , "Serge E. Hallyn" , Mimi Zohar , "David S. Miller" , Jakub Kicinski , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen Jarkko Sakkinen wrote: > /* Key data can change as we don not hold key->sem. */ I think you mean "we don't". David