From mboxrd@z Thu Jan 1 00:00:00 1970 From: nayna Date: Tue, 15 Jan 2019 15:17:13 +0000 Subject: Re: [RFC PATCH 2/2] kexec, KEYS: Make use of platform keyring for signature verify Message-Id: <3c80c88c90ead96cea9a4f13af41fc5b@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: References: <20190109164824.19708-1-kasong@redhat.com> <20190109164824.19708-3-kasong@redhat.com> <20190111134303.GA12760@dhcp-128-65.nay.redhat.com> <1547223220.19931.471.camel@linux.ibm.com> <20190113013958.GA14019@dhcp-128-65.nay.redhat.com> <1547482251.4156.127.camel@linux.ibm.com> <20190115024243.GA9199@dhcp-128-65.nay.redhat.com> In-Reply-To: <20190115024243.GA9199@dhcp-128-65.nay.redhat.com> To: Dave Young Cc: Mimi Zohar , Kairui Song , linux-kernel@vger.kernel.org, dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org On 2019-01-14 21:42, Dave Young wrote: > On 01/14/19 at 11:10am, Mimi Zohar wrote: >> On Sun, 2019-01-13 at 09:39 +0800, Dave Young wrote: >> > Hi, >> > >> > On 01/11/19 at 11:13am, Mimi Zohar wrote: >> > > On Fri, 2019-01-11 at 21:43 +0800, Dave Young wrote: >> > > [snip] >> > > >> > > > Personally I would like to see platform key separated from integrity. >> > > > But for the kexec_file part I think it is good at least it works with >> > > > this fix. >> > > > >> > > > Acked-by: Dave Young >> > > >> > > The original "platform" keyring patches that Nayna posted multiple >> > > times were in the certs directory, but nobody commented/responded.  So >> > > she reworked the patches, moving them to the integrity directory and >> > > posted them (cc'ing the kexec mailing list).  It's a bit late to be >> > > asking to move it, isn't it? >> > >> > Hmm, apologize for being late, I did not get chance to have a look the >> > old series. Since we have the needs now, it should be still fine >> > >> > Maybe Kairui can check Nayna's old series, see if he can do something >> > again? >> >> Whether the platform keyring is defined in certs/ or in integrity/ the >> keyring id needs to be accessible to the other, without making the >> keyring id global.  Moving where the platform keyring is defined is >> not the problem. > > Agreed, but just feel kexec depends on IMA sounds not good. The platform keyring is not dependent on IMA, it is dependent on "integrity" - CONFIG_INTEGRITY_ASYMMETRIC_KEYS. Other CONFIGS which it needs are CONFIG_SYSTEM_BLACKLIST_KEYRING, CONFIG_EFI. Thanks & Regards, - Nayna