[PATCH 2/2] keys: Remove unnecessary local variable from proc_keys_show

Thorsten Blum
2025-10-23T14:33:30Z

The local variable 'rc' is only used to temporary store the result of
calling key_task_permission(). Use the result directly and remove the
local variable.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
security/keys/proc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/security/keys/proc.c b/security/keys/proc.c
index 4f4e2c1824f1..39af57af2aad 100644
--- a/security/keys/proc.c
+++ b/security/keys/proc.c
@@ -160,7 +160,6 @@ static int proc_keys_show(struct seq_file *m, void *v)
char xbuf[16];
short state;
u64 timo;
- int rc;

struct keyring_search_context ctx = {
.index_key = key->index_key,
@@ -188,8 +187,7 @@ static int proc_keys_show(struct seq_file *m, void *v)
}

/* check whether the current task is allowed to view the key */
- rc = key_task_permission(key_ref, ctx.cred, KEY_NEED_VIEW);
- if (rc < 0)
+ if (key_task_permission(key_ref, ctx.cred, KEY_NEED_VIEW) < 0)
return 0;

now = ktime_get_real_seconds();
--
2.51.0