public inbox for keyrings@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: David Howells <dhowells@redhat.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Fix typos in 'struct key_type' function pointer comments
Date: Fri, 24 Oct 2025 22:04:08 +0300	[thread overview]
Message-ID: <aPvNqCRlMN5c8GaR@kernel.org> (raw)
In-Reply-To: <20251016123619.98728-2-thorsten.blum@linux.dev>

 On Thu, Oct 16, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:
> s/it/if/ and s/revokation/revocation/
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  include/linux/key-type.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/key-type.h b/include/linux/key-type.h
> index 5caf3ce82373..5eb2e64803db 100644
> --- a/include/linux/key-type.h
> +++ b/include/linux/key-type.h
> @@ -107,11 +107,11 @@ struct key_type {
>  	 */
>  	int (*match_preparse)(struct key_match_data *match_data);
>  
> -	/* Free preparsed match data (optional).  This should be supplied it
> +	/* Free preparsed match data (optional).  This should be supplied if
>  	 * ->match_preparse() is supplied. */

The comment is also formatted incorrectly. It should be:

	/* 
	 * Free preparsed match data (optional).  This should be supplied if
	 * ->match_preparse() is supplied. 
	 */

>  	void (*match_free)(struct key_match_data *match_data);
>  
> -	/* clear some of the data from a key on revokation (optional)
> +	/* clear some of the data from a key on revocation (optional)
>  	 * - the key's semaphore will be write-locked by the caller
>  	 */

Ditto.

>  	void (*revoke)(struct key *key);
> -- 
> 2.51.0
> 

BR, Jarkko

  reply	other threads:[~2025-10-24 19:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 12:36 [PATCH] keys: Fix typos in 'struct key_type' function pointer comments Thorsten Blum
2025-10-24 19:04 ` Jarkko Sakkinen [this message]
2025-10-24 20:29   ` Thorsten Blum
2025-10-27 20:11     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPvNqCRlMN5c8GaR@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox