Re: [PATCH v13 12/12] pkcs7: Add ML-DSA FIPS selftest

Eric Biggers
2026-01-20T21:43:54Z

On Tue, Jan 20, 2026 at 02:50:58PM +0000, David Howells wrote:
> Add a FIPS selftest for ML-DSA.

I already did that. See mldsa_mod_init() in lib/crypto/mldsa.c.

You may be misunderstanding what FIPS 140 requires. It requires a
self-test for the underlying algorithm, i.e. ML-DSA in this case. It
doesn't require a self-test for code that uses the algorithm, i.e. the
CMS and X.509 code in this case.

The CMS and X.509 code needs to be tested of course, but that's just
standard software development. Nothing to do with FIPS 140. The test
should just be a standard KUnit test.

- Eric