public inbox for keyrings@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by
       [not found] <20260409073711.57020-4-thorsten.blum@linux.dev>
@ 2026-04-09  7:37 ` Thorsten Blum
  2026-04-09 17:37   ` David Howells
  0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2026-04-09  7:37 UTC (permalink / raw)
  To: David Howells, Jarkko Sakkinen, Kees Cook, Gustavo A. R. Silva
  Cc: Thorsten Blum, netdev, keyrings, linux-kernel, linux-hardening

Add the __counted_by() compiler attribute to the flexible array member
'data' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
Resending this because patch 2/2 didn't go to netdev@ (Jakub)
Cc: netdev@vger.kernel.org
---
 include/keys/user-type.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/keys/user-type.h b/include/keys/user-type.h
index 386c31432789..2305991f4fcd 100644
--- a/include/keys/user-type.h
+++ b/include/keys/user-type.h
@@ -27,7 +27,8 @@
 struct user_key_payload {
 	struct rcu_head	rcu;		/* RCU destructor */
 	unsigned short	datalen;	/* length of this data */
-	char		data[] __aligned(__alignof__(u64)); /* actual data */
+	char		data[]		/* actual data */
+			__aligned(__alignof__(u64)) __counted_by(datalen);
 };
 
 extern struct key_type key_type_user;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by
  2026-04-09  7:37 ` [PATCH RESEND net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum
@ 2026-04-09 17:37   ` David Howells
  2026-04-09 18:27     ` Thorsten Blum
  0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2026-04-09 17:37 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: dhowells, Jarkko Sakkinen, Kees Cook, Gustavo A. R. Silva, netdev,
	keyrings, linux-kernel, linux-hardening

Thorsten Blum <thorsten.blum@linux.dev> wrote:

> +			__aligned(__alignof__(u64)) __counted_by(datalen);

Can that be __aligned(8)?

David


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by
  2026-04-09 17:37   ` David Howells
@ 2026-04-09 18:27     ` Thorsten Blum
  0 siblings, 0 replies; 3+ messages in thread
From: Thorsten Blum @ 2026-04-09 18:27 UTC (permalink / raw)
  To: David Howells
  Cc: Jarkko Sakkinen, Kees Cook, Gustavo A. R. Silva, netdev, keyrings,
	linux-kernel, linux-hardening

On Thu, Apr 09, 2026 at 06:37:13PM +0100, David Howells wrote:
> Thorsten Blum <thorsten.blum@linux.dev> wrote:
> 
> > +			__aligned(__alignof__(u64)) __counted_by(datalen);
> 
> Can that be __aligned(8)?

Sure, I can send a v2 with __aligned(8).

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-09 18:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260409073711.57020-4-thorsten.blum@linux.dev>
2026-04-09  7:37 ` [PATCH RESEND net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum
2026-04-09 17:37   ` David Howells
2026-04-09 18:27     ` Thorsten Blum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox