From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Date: Fri, 24 May 2019 19:38:39 +0000 Subject: Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed() Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <155856408314.10428.17035328117829912815.stgit@warthog.procyon.org.uk> <155856409010.10428.11692778420533145488.stgit@warthog.procyon.org.uk> In-Reply-To: <155856409010.10428.11692778420533145488.stgit@warthog.procyon.org.uk> To: David Howells Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 22 May 2019, David Howells wrote: > Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected > accesses of tsk->cred, which is marked __rcu. > > Fix this by passing the new cred struct to these functions from > commit_creds() rather than the task pointer. > > Signed-off-by: David Howells Reviewed-by: James Morris -- James Morris