From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Kenzior Date: Tue, 26 Mar 2019 14:59:40 +0000 Subject: Re: Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED' Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <7cd8d12f59bcacd18a78f599b46dac555f7f16c0.camel@perches.com> <20190325212705.26837-1-joe@perches.com> <20190326113725.GA10898@linux.intel.com> <1553602220.3960.29.camel@linux.ibm.com> <1553610317.2900.2.camel@linux.ibm.com> In-Reply-To: <1553610317.2900.2.camel@linux.ibm.com> To: James Bottomley , Mimi Zohar , Jarkko Sakkinen , Joe Perches Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, Mimi Zohar , David Howells , James Morris , Marcel Holtmann , James Morris Hi James, On 03/26/2019 09:25 AM, James Bottomley wrote: > Looking at the contents of linux/keys/trusted.h, it looks like the > wrong decision to move it. The contents are way too improperly named > and duplicative to be in a standard header. It's mostly actually TPM > code including a redefinition of the tpm_buf structure, so it doesn't > even seem to be necessary for trusted keys. The reason this was done was because asym_tpm.c needed a bunch of the same functionality already provided by trusted.c, e.g. TSS_authmac and friends. > > If you want to fix this as a bug, I'd move it back again, but long term > I think it should simply be combined with trusted.c because nothing > else can include it sanely anyway. Ideally I'd like to see the TPM subsystem expose these functions using some proper API / library abstraction. David Howells had an RFC patch set that tried to address some of this a while back. Not sure if that went anywhere. Regards, -Denis