Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Pull network and Patch Acceptance Consistency

Martin K. Petersen
2019-06-14T03:03:34Z

Mauro,

> Using astyle:
>
> $ astyle --indent=force-tab=8 --convert-tabs --style=linux
> --lineend=linux --pad-oper --pad-comma --pad-header
> --align-pointer=name --align-reference=name --break-one-line-headers
> drivers/scsi/gdth_proc.c
>
> A visual inspection on it looked pretty decent to my eyes. The
> automatic tool also reported a lot less issues:

Not questioning that things could be cleaned up and that tools can
help. However, many of these drivers will be removed when we get the
chance so it doesn't seem worthwhile to invest in reformatting and
updating them. Especially if cleaning things up will facilitate *more*
drive-by patches. I'd much rather let stale be stale to make it clear
that a given driver will be dropped from the tree unless somebody shows
a real interest.

While this may come across as a desire to discourage patches completely,
that's not actually the case. But I want patches from somebody who takes
ownership and who is willing to validate things. Using real hardware,
QEMU, output comparison, or interpretive dancing. Doesn't matter.

I am a bit concerned that our emphasis on teaching process to attract
new talent has encouraged a culture of non-committal drive-by cleanups.
Whereas I think there is much to be learned from the process of buying
an obsolete SCSI controller on eBay, beating a driver into shape,
getting the changes merged, and committing to maintaining things going
forward.

--
Martin K. Petersen Oracle Linux Engineering