Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Pull network and Patch Acceptance Consistency

Mauro Carvalho Chehab
2019-06-14T03:35:45Z

Em Thu, 13 Jun 2019 23:03:15 -0400
"Martin K. Petersen" <martin.petersen@oracle.com> escreveu:

> Mauro,
>
> > Using astyle:
> >
> > $ astyle --indent=force-tab=8 --convert-tabs --style=linux
> > --lineend=linux --pad-oper --pad-comma --pad-header
> > --align-pointer=name --align-reference=name --break-one-line-headers
> > drivers/scsi/gdth_proc.c
> >
> > A visual inspection on it looked pretty decent to my eyes. The
> > automatic tool also reported a lot less issues:
>
> Not questioning that things could be cleaned up and that tools can
> help. However, many of these drivers will be removed when we get the
> chance so it doesn't seem worthwhile to invest in reformatting and
> updating them. Especially if cleaning things up will facilitate *more*
> drive-by patches. I'd much rather let stale be stale to make it clear
> that a given driver will be dropped from the tree unless somebody shows
> a real interest.
>
> While this may come across as a desire to discourage patches completely,
> that's not actually the case. But I want patches from somebody who takes
> ownership and who is willing to validate things. Using real hardware,
> QEMU, output comparison, or interpretive dancing. Doesn't matter.
>
> I am a bit concerned that our emphasis on teaching process to attract
> new talent has encouraged a culture of non-committal drive-by cleanups.
> Whereas I think there is much to be learned from the process of buying
> an obsolete SCSI controller on eBay, beating a driver into shape,
> getting the changes merged, and committing to maintaining things going
> forward.

Understood. Yeah, investing time on obsolete drivers is probably
not worth and may attract people to do just cleanup patches. We have
a few such drivers on media that are there only because we don't have
any strong reason to send them to /dev/null. So, basically, they're
waiting for an excuse to be trashed.

We actually do that: from time to time, as we need to change some things
at the core, we decide to move obsoleted to drivers/staging, and, if
nobody takes any action to claim its maintainership, after a couple
of Kernel releases, we send them to the trash can.

The comments I made are more related to things that the subsystem
maintainers want to keep and may have serious coding style issues.

If there are such kind of code, IMO, it makes sense to use a
tool like astyle, plus checkpatch --fix-inline in order to make the
code to be closer to the current coding style, specially at the
subsystem's core, as this may help to keep the Kernel coding style
coherent among different subsystems, with seems to be the point that
James raised with the "Patch Acceptance Consistency" topic.

Thanks,
Mauro